shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-03-30 10:50:34 +03:00
Code Releases Activity

Update lvm_vg_extend to do an implicit pvcreate on the device.

Browse Source 
Although the tools do not currently do this, we update lvm_vg_extend
to do an implicit pvcreate on an uninitialized device.  The tools will
soon be refactored to do this as well, but more work is needed in the
tools.  For now we update lvm_vg_extend since this is the behavior
required by liblvm.
With this change, the simple liblvm unit test, test/api/vgtest.c
should pass whether or not the device is initialized.


Author: Dave Wysochanski <dwysocha@redhat.com>
This commit is contained in:
Dave Wysochanski 2009-07-26 01:54:40 +00:00
parent 3a821c040e
commit aaeec65415
2 changed files with 16 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
liblvm/lvm.h
View File

@ -146,6 +146,10 @@ vg_t *lvm_vg_create(lvm_t libh, const char *vg_name);
* After successfully adding a device, use lvm_vg_write to commit the new VG
* to disk. Upon failure, retry the operation or release the VG handle with
* lvm_vg_close.
* If the device is not initialized for LVM use, it will be initialized
* before adding to the VG. Although some internal checks are done,
* the caller should be sure the device is not in use by other subsystems
* before calling lvm_vg_extend.
*
* \param vg
* VG handle obtained from lvm_vg_create.

15
liblvm/lvm_vg.c
View File

@ -12,9 +12,6 @@
* Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
*/
#include <errno.h>
#include <string.h>
#include "lib.h"
#include "lvm.h"
#include "toolcontext.h"
@ -23,6 +20,10 @@
#include "locking.h"
#include "lvm-string.h"
#include "lvmcache.h"
#include "metadata.h"
#include <errno.h>
#include <string.h>
vg_t *lvm_vg_create(lvm_t libh, const char *vg_name)
{
@ -47,6 +48,14 @@ int lvm_vg_extend(vg_t *vg, const char *device)
return 0;
}
/* If device not initialized, pvcreate it */
if (!pv_by_path(vg->cmd, device) &&
(!pvcreate_single(vg->cmd, device, NULL))) {
log_error("Unable to initialize device for LVM use\n");
unlock_vg(vg->cmd, VG_ORPHANS);
return 0;
}
if (!vg_extend(vg, 1, (char **) &device)) {
unlock_vg(vg->cmd, VG_ORPHANS);
return 0;