shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

libdm: validate thin-pool before sending messages

Browse Source 
Alhtough lvm2 does validation on its side, ensure DM code
is not sending messages to failed thin pool.
This commit is contained in:
Zdenek Kabelac 2020-09-28 23:12:48 +02:00
parent 4b0565b82f
commit b2a326b511
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
libdm/libdm-deptree.c
View File

@ -1600,6 +1600,15 @@ static int _node_send_messages(struct dm_tree_node *dnode,
if (!have_messages || !send) if (!have_messages || !send)
return 1; /* transaction_id is matching */ return 1; /* transaction_id is matching */
if (stp.fail || stp.read_only || stp.needs_check) {
log_error("Cannot send messages to thin pool %s%s%s%s.",
_node_name(dnode),
stp.fail ? " in failed state" : "",
stp.read_only ? " with read only metadata" : "",
stp.needs_check ? " which needs check first" : "");
return 0;
}
dm_list_iterate_items(tmsg, &seg->thin_messages) { dm_list_iterate_items(tmsg, &seg->thin_messages) {
if (!(_thin_pool_node_message(dnode, tmsg))) if (!(_thin_pool_node_message(dnode, tmsg)))
return_0; return_0;