From b36ab8a0639e85a5674a83808ccbb526a7191699 Mon Sep 17 00:00:00 2001 From: Wu Guanghao Date: Mon, 30 Aug 2021 15:13:00 +0800 Subject: [PATCH] cmdlib_lvm2_init: release cmd on failure path The cmd memory space is allocated by zalloc, and the registration fails and is not released. Although this code would be ever triggered just in the case of some internal (likely compilation) bug. Signed-off-by: Wu Guanghao --- tools/lvmcmdlib.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/lvmcmdlib.c b/tools/lvmcmdlib.c index 152d176b2..6b326893c 100644 --- a/tools/lvmcmdlib.c +++ b/tools/lvmcmdlib.c @@ -33,8 +33,10 @@ void *cmdlib_lvm2_init(unsigned static_compile, unsigned threaded) if (!(cmd = init_lvm(1, 1, threaded))) return NULL; - if (!lvm_register_commands(cmd, NULL)) + if (!lvm_register_commands(cmd, NULL)) { + free(cmd); return NULL; + } return (void *) cmd; }