From b3a13b17cba931f0aee0afa9c7407cefce227186 Mon Sep 17 00:00:00 2001 From: Dave Wysochanski Date: Fri, 9 Jul 2010 16:57:44 +0000 Subject: [PATCH] Add log_error when strdup fails in {vg|lv}_change_tag(). Signed-off-by: Dave Wysochanski --- lib/metadata/metadata.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/metadata/metadata.c b/lib/metadata/metadata.c index cded84985..07222a7cb 100644 --- a/lib/metadata/metadata.c +++ b/lib/metadata/metadata.c @@ -723,7 +723,9 @@ int lv_change_tag(struct logical_volume *lv, const char *tag, int add_tag) if (add_tag) { if (!(tag_new = dm_pool_strdup(lv->vg->vgmem, tag))) { - return_0; + log_error("Failed to duplicate tag %s from %s/%s", + tag, lv->vg->name, lv->name); + return 0; } if (!str_list_add(lv->vg->vgmem, &lv->tags, tag_new)) { log_error("Failed to add tag %s to %s/%s", @@ -751,7 +753,9 @@ int vg_change_tag(struct volume_group *vg, const char *tag, int add_tag) if (add_tag) { if (!(tag_new = dm_pool_strdup(vg->vgmem, tag))) { - return_0; + log_error("Failed to duplicate tag %s from %s", + tag, vg->name); + return 0; } if (!str_list_add(vg->vgmem, &vg->tags, tag_new)) { log_error("Failed to add tag %s to volume group %s",