shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-03-10 16:58:47 +03:00
Code Releases Activity

Fix and clarify vgsplit error messages.

Browse Source
This commit is contained in:
Milan Broz 2007-05-15 13:01:41 +00:00
parent 76b74ab11f
commit b3b0f199ae
2 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
WHATS_NEW
View File

@ -1,5 +1,6 @@
Version 2.02.26 - Version 2.02.26 -
================================= =================================
Fix and clarify vgsplit error messages.
Fix a segfault if a device has no target (no table) Fix a segfault if a device has no target (no table)
Add some more debuglogs to clvmd startup. Add some more debuglogs to clvmd startup.
Misc clvmd cleanups Misc clvmd cleanups

18
tools/vgsplit.c
View File

@ -145,13 +145,16 @@ static int _move_snapshots(struct volume_group *vg_from,
list_iterate_items(seg, &lv->segments) { list_iterate_items(seg, &lv->segments) {
cow_from = _lv_is_in_vg(vg_from, seg->cow); cow_from = _lv_is_in_vg(vg_from, seg->cow);
origin_from = _lv_is_in_vg(vg_from, seg->origin); origin_from = _lv_is_in_vg(vg_from, seg->origin);
if (cow_from && origin_from)
continue;
if ((!cow_from && origin_from) ||
(cow_from && !origin_from)) {
log_error("Can't split snapshot %s between"
" two Volume Groups", seg->cow->name);
return 0;
}
} }
if (cow_from && origin_from)
continue;
if ((!cow_from && origin_from) || (cow_from && !origin_from)) {
log_error("Snapshot %s split", seg->cow->name);
return 0;
}
/* Move this snapshot */ /* Move this snapshot */
list_del(lvh); list_del(lvh);
@ -190,7 +193,8 @@ static int _move_mirrors(struct volume_group *vg_from,
if ((seg_in && seg_in < seg->area_count) || if ((seg_in && seg_in < seg->area_count) ||
(seg_in && seg->log_lv && !log_in) || (seg_in && seg->log_lv && !log_in) ||
(!seg_in && seg->log_lv && log_in)) { (!seg_in && seg->log_lv && log_in)) {
log_error("Mirror %s split", lv->name); log_error("Can't split mirror %s between "
"two Volume Groups", lv->name);
return 0; return 0;
} }