diff --git a/WHATS_NEW b/WHATS_NEW index c273a92af..e3f179929 100644 --- a/WHATS_NEW +++ b/WHATS_NEW @@ -1,5 +1,6 @@ Version 2.02.29 - ================================== + Fix --addtag to drop @ prefix from name. Stop clvmd going haywire if a pre_function fails. Convert some vg_reads into vg_lock_and_reads. Avoid nested vg_reads when processing PVs in VGs and fix associated locking. diff --git a/tools/lvmcmdline.c b/tools/lvmcmdline.c index 9ef88b877..116195a23 100644 --- a/tools/lvmcmdline.c +++ b/tools/lvmcmdline.c @@ -333,6 +333,8 @@ int tag_arg(struct cmd_context *cmd __attribute((unused)), struct arg *a) if (!validate_name(pos)) return 0; + a->value = pos; + return 1; } diff --git a/tools/vgsplit.c b/tools/vgsplit.c index f641ad2e3..fdeed5424 100644 --- a/tools/vgsplit.c +++ b/tools/vgsplit.c @@ -243,6 +243,7 @@ int vgsplit(struct cmd_context *cmd, int argc, char **argv) if ((vg_to = vg_lock_and_read(cmd, vg_name_to, NULL, LCK_VG_WRITE | LCK_NONBLOCK, 0, 0))) { + /* FIXME Remove this restriction */ log_error("Volume group \"%s\" already exists", vg_name_to); unlock_vg(cmd, vg_name_from); return ECMD_FAILED;