shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-02-27 01:57:55 +03:00
Code Releases Activity

lvconvert: more support for yes conversion

Browse Source 
When converting volume to pool LV use also wiping of other signatures.
For writecache & pool conversion support --yet and --force
to bypass prompting for signature wiping.
For writecache drop unneded zero_sectors.

Note: currently we have lvconvert doing convertion and prompting
for confirmation of conversion - and then again wipe_lv() prompts
for removing i.e. filesystem signature - we should unify this
prompting into 1 message  - althought the 'filesystem' discovery
needs active volume - while the 1st. conversion prompt can
work without active converted volume.
This commit is contained in:
Zdenek Kabelac 2020-07-08 10:57:52 +02:00
parent fe78cd4082
commit b7f3667ce2
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
tools/lvconvert.c
View File

@ -3279,7 +3279,11 @@ static int _lvconvert_to_pool(struct cmd_context *cmd,
} }
metadata_lv->status &= ~LV_ACTIVATION_SKIP; metadata_lv->status &= ~LV_ACTIVATION_SKIP;
if (!wipe_lv(metadata_lv, (struct wipe_params) { .do_zero = 1 })) { if (!wipe_lv(metadata_lv, (struct wipe_params) {
.do_wipe_signatures = 1,
.is_metadata = 1,
.yes = arg_count(cmd, yes_ARG),
.force = arg_count(cmd, force_ARG) } )) {
log_error("Aborting. Failed to wipe metadata lv."); log_error("Aborting. Failed to wipe metadata lv.");
goto bad; goto bad;
} }
@ -5502,7 +5506,8 @@ static int _writecache_zero(struct cmd_context *cmd, struct logical_volume *lv)
struct wipe_params wp = { struct wipe_params wp = {
.do_wipe_signatures = 1, /* optional, to print warning if clobbering something */ .do_wipe_signatures = 1, /* optional, to print warning if clobbering something */
.do_zero = 1, /* required for dm-writecache to work */ .do_zero = 1, /* required for dm-writecache to work */
.zero_sectors = 1 .yes = arg_count(cmd, yes_ARG),
.force = arg_count(cmd, force_ARG)
}; };
int ret; int ret;