shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-01-02 01:18:26 +03:00
Code Releases Activity

writecache: use wipe_lv to warn about specific signatures

Browse Source 
When initializing an LV to hold the writecache, use wipe_lv()
which looks for specific signatures on the LV.

Wiping signatures is not necessary, but printing a warning
that names a specific signature (in addition to the existing
generic warning/confirmation) may help if a user accidentally
specifies the wrong LV which contains something important.
This commit is contained in:
David Teigland 2019-01-03 10:37:26 -06:00
parent 938b6b8253
commit bc40391b7d
1 changed files with 9 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
tools/lvconvert.c
View File

@ -5230,44 +5230,23 @@ static int _lvconvert_detach_writecache(struct cmd_context *cmd,
static int _writecache_zero(struct cmd_context *cmd, struct logical_volume *lv) static int _writecache_zero(struct cmd_context *cmd, struct logical_volume *lv)
{ {
struct device *dev; struct wipe_params wp;
char name[PATH_MAX]; int ret;
int ret = 0;
if (!activate_lv(cmd, lv)) { if (!activate_lv(cmd, lv)) {
log_error("Failed to activate LV %s for zeroing.", lv->name); log_error("Failed to activate LV %s for zeroing.", display_lvname(lv));
return 0; return 0;
} }
sync_local_dev_names(cmd); wp.do_wipe_signatures = 1; /* optional, to print warning if clobbering something */
wp.do_zero = 1; /* required for dm-writecache to work */
wp.zero_sectors = 1;
wp.zero_value = 0;
if (dm_snprintf(name, sizeof(name), "%s%s/%s", ret = wipe_lv(lv, wp);
cmd->dev_dir, lv->vg->name, lv->name) < 0) {
log_error("Name too long - device not cleared (%s)", lv->name);
goto out;
}
if (!(dev = dev_cache_get(cmd, name, NULL))) {
log_error("%s: not found: device not zeroed", name);
goto out;
}
if (!label_scan_open(dev)) {
log_error("Failed to open %s/%s for zeroing.", lv->vg->name, lv->name);
goto out;
}
if (!dev_write_zeros(dev, UINT64_C(0), (size_t) 1 << SECTOR_SHIFT))
goto_out;
log_debug("Zeroed the first sector of %s", lv->name);
label_scan_invalidate(dev);
ret = 1;
out:
if (!deactivate_lv(cmd, lv)) { if (!deactivate_lv(cmd, lv)) {
log_error("Failed to deactivate LV %s for zeroing.", lv->name); log_error("Failed to deactivate LV %s for zeroing.", display_lvname(lv));
ret = 0; ret = 0;
} }