shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-03-10 16:58:47 +03:00
Code Releases Activity

devices file: remove extraneous unlock in vgchange -u

Browse Source 
vgchange -u exit path was unlocking the devices file in cases
when it wasn't needed, which produced an warning.
This commit is contained in:
David Teigland 2022-04-13 12:16:57 -05:00
parent d14245c724
commit bee575d678
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/device/device_id.c
View File

@ -1298,15 +1298,15 @@ void device_id_update_vg_uuid(struct cmd_context *cmd, struct volume_group *vg,
int update = 0; int update = 0;
if (!cmd->enable_devices_file) if (!cmd->enable_devices_file)
goto out; return;
/* Without this setting there is no stacking LVs on PVs. */ /* Without this setting there is no stacking LVs on PVs. */
if (!cmd->scan_lvs) if (!cmd->scan_lvs)
goto out; return;
/* Check if any devices file entries are stacked on LVs. */ /* Check if any devices file entries are stacked on LVs. */
if (!_device_ids_use_lvmlv(cmd)) if (!_device_ids_use_lvmlv(cmd))
goto out; return;
memcpy(old_vgid, old_vg_id, ID_LEN); memcpy(old_vgid, old_vg_id, ID_LEN);
memcpy(new_vgid, &vg->id, ID_LEN); memcpy(new_vgid, &vg->id, ID_LEN);
@ -1336,7 +1336,6 @@ void device_id_update_vg_uuid(struct cmd_context *cmd, struct volume_group *vg,
if (update && if (update &&
!device_ids_write(cmd)) !device_ids_write(cmd))
stack; stack;
out:
unlock_devices_file(cmd); unlock_devices_file(cmd);
} }