From c0a0eedf2e572b99e40384e68e3d5f8fba6f0ae5 Mon Sep 17 00:00:00 2001 From: Heinz Mauelshagen Date: Tue, 16 Aug 2016 23:57:09 +0200 Subject: [PATCH] vgsplit: fix regression processing thin external origins a579ba2ac27d fixed a regression causing a segfault if no external origin existed but broke the logic leading to erroneous error messages and creations of split off exported VGs in case the external origin and the pool LVs were allocated on different PVs. - resolves rhbz1367459 --- tools/vgsplit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/vgsplit.c b/tools/vgsplit.c index 93161c17d..52f603f9a 100644 --- a/tools/vgsplit.c +++ b/tools/vgsplit.c @@ -331,7 +331,7 @@ static int _move_thins(struct volume_group *vg_from, data_lv = seg_lv(first_seg(seg->pool_lv), 0); /* Ignore, if no allocations on PVs of @vg_to */ - if (!lv_is_on_pvs(data_lv, &vg_to->pvs) || + if (!lv_is_on_pvs(data_lv, &vg_to->pvs) && (seg->external_lv && !lv_is_on_pvs(seg->external_lv, &vg_to->pvs))) continue;