shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-01-02 01:18:26 +03:00
Code Releases Activity

filter: do not check for suspended devs in filter-usable in lvmetad mode

Browse Source 
We already do check for suspended devs within udev rules where
the pvscan is to update lvmetad. So the check for suspended devs
in "pre-lvmetad" chain is not useful here - remove it - it may
be a source of hardly to detect races anyway (if udev rule detects
the device is not suspended and then the pvscan instance sees the
dev as suspended, we may end up not reacting to the event properly).
This commit is contained in:
Peter Rajnoha 2016-02-03 14:40:52 +01:00
parent 1498bc8cc4
commit c0e0f5a923
2 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
WHATS_NEW
View File

@ -1,5 +1,6 @@
Version 2.02.142 - Version 2.02.142 -
==================================== ====================================
Do not check for suspended devices if scanning for lvmetad update.
Fix part. table filter with external_device_info_source="udev" and blkid<2.20. Fix part. table filter with external_device_info_source="udev" and blkid<2.20.
Version 2.02.141 - 25th January 2016 Version 2.02.141 - 25th January 2016

9
lib/filters/filter-usable.c
View File

@ -126,15 +126,8 @@ static int _passes_usable_filter(struct dev_filter *f, struct device *dev)
break; break;
case FILTER_MODE_PRE_LVMETAD: case FILTER_MODE_PRE_LVMETAD:
ucp.check_empty = 1; ucp.check_empty = 1;
/*
* If we're scanning for lvmetad update,
* we don't want to hang on blocked/suspended devices.
* When the device is unblocked/resumed, surely,
* there's going to be a CHANGE event so the device
* gets scanned via udev rule anyway after resume.
*/
ucp.check_blocked = 1; ucp.check_blocked = 1;
ucp.check_suspended = 1; ucp.check_suspended = 0;
ucp.check_error_target = 1; ucp.check_error_target = 1;
ucp.check_reserved = 1; ucp.check_reserved = 1;
break; break;