shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-08-05 16:22:02 +03:00
Code Releases Activity

const: tests

Browse Source
This commit is contained in:
Zdenek Kabelac
2024-05-07 22:06:35 +02:00
parent edbc0ed447
commit c48cc22b18
4 changed files with 28 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
test/unit/bcache_t.c
View File

@ -427,7 +427,7 @@ static void test_block_size_must_be_positive(void *fixture)
static void test_block_size_must_be_multiple_of_page_size(void *fixture) static void test_block_size_must_be_multiple_of_page_size(void *fixture)
{ {
static unsigned _bad_examples[] = {3, 9, 13, 1025}; static const unsigned _bad_examples[] = {3, 9, 13, 1025};
unsigned i; unsigned i;

8
test/unit/matcher_data.h
View File

@ -3,13 +3,13 @@ struct check_item {
int expected; int expected;
}; };
static const char *dev_patterns[] = { static const char * const dev_patterns[] = {
"loop/[0-9]+", "loop/[0-9]+",
"hd[a-d][0-5]+", "hd[a-d][0-5]+",
NULL NULL
}; };
static const char *nonprint_patterns[] = { static const char * const nonprint_patterns[] = {
"foo\x80" "bar", "foo\x80" "bar",
"foo\xc2" "b", "foo\xc2" "b",
"\x80", "\x80",
@ -24,7 +24,7 @@ static const struct check_item nonprint[] = {
{ NULL, 0 } { NULL, 0 }
}; };
static const char *random_patterns[] = { static const char * const random_patterns[] = {
"(((a?)(([Ub]*)|z))((([qr]|X)+)([Qn]*)))+", "(((a?)(([Ub]*)|z))((([qr]|X)+)([Qn]*)))+",
"[HZejtuw]*", "[HZejtuw]*",
"((B|s)*)|(((([Fv]l)(N+))(([el]|C)(tJ)))?)", "((B|s)*)|(((([Fv]l)(N+))(([el]|C)(tJ)))?)",
@ -128,7 +128,7 @@ static const char *random_patterns[] = {
NULL NULL
}; };
struct check_item devices[] = { static const struct check_item devices[] = {
{ "/dev", 0 }, { "/dev", 0 },
{ "/dev/.devfsd", 0 }, { "/dev/.devfsd", 0 },
{ "/dev/cpu", 0 }, { "/dev/cpu", 0 },

6
test/unit/matcher_t.c
View File

@ -34,7 +34,7 @@ static void _mem_exit(void *mem)
dm_pool_destroy(mem); dm_pool_destroy(mem);
} }
static struct dm_regex *make_scanner(struct dm_pool *mem, const char **rx) static struct dm_regex *make_scanner(struct dm_pool *mem, const char * const *rx)
{ {
struct dm_regex *scanner; struct dm_regex *scanner;
int nrx = 0; int nrx = 0;
@ -75,11 +75,11 @@ static void test_matching(void *fixture)
static void test_kabi_query(void *fixture) static void test_kabi_query(void *fixture)
{ {
// Remember, matches regexes from last to first. // Remember, matches regexes from last to first.
static const char *_patterns[] = { static const char * const _patterns[] = {
".*", ".*/dev/md.*", "loop" ".*", ".*/dev/md.*", "loop"
}; };
static struct { static const struct {
const char *input; const char *input;
int r; int r;
} _cases[] = { } _cases[] = {

38
test/unit/vdo_t.c
View File

@ -17,7 +17,7 @@
//---------------------------------------------------------------- //----------------------------------------------------------------
static bool _status_eq(struct dm_vdo_status *lhs, struct dm_vdo_status *rhs) static bool _status_eq(const struct dm_vdo_status *lhs, const struct dm_vdo_status *rhs)
{ {
return !strcmp(lhs->device, rhs->device) && return !strcmp(lhs->device, rhs->device) &&
(lhs->operating_mode == rhs->operating_mode) && (lhs->operating_mode == rhs->operating_mode) &&
@ -83,12 +83,12 @@ struct example_good {
struct dm_vdo_status status; struct dm_vdo_status status;
}; };
static void _check_good(struct example_good *es, unsigned count) static void _check_good(const struct example_good *es, unsigned count)
{ {
unsigned i; unsigned i;
for (i = 0; i < count; i++) { for (i = 0; i < count; i++) {
struct example_good *e = es + i; const struct example_good *e = es + i;
struct dm_vdo_status_parse_result pr; struct dm_vdo_status_parse_result pr;
T_ASSERT(dm_vdo_status_parse(NULL, e->input, &pr)); T_ASSERT(dm_vdo_status_parse(NULL, e->input, &pr));
@ -109,12 +109,12 @@ struct example_bad {
const char *reason; const char *reason;
}; };
static void _check_bad(struct example_bad *es, unsigned count) static void _check_bad(const struct example_bad *es, unsigned count)
{ {
unsigned i; unsigned i;
for (i = 0; i < count; i++) { for (i = 0; i < count; i++) {
struct example_bad *e = es + i; const struct example_bad *e = es + i;
struct dm_vdo_status_parse_result pr; struct dm_vdo_status_parse_result pr;
T_ASSERT(!dm_vdo_status_parse(NULL, e->input, &pr)); T_ASSERT(!dm_vdo_status_parse(NULL, e->input, &pr));
@ -124,7 +124,7 @@ static void _check_bad(struct example_bad *es, unsigned count)
static void _test_device_names_good(void *fixture) static void _test_device_names_good(void *fixture)
{ {
static struct example_good _es[] = { static const struct example_good _es[] = {
{"foo1234 read-only - error online 0 1234", {"foo1234 read-only - error online 0 1234",
{(char *) "foo1234", DM_VDO_MODE_READ_ONLY, false, DM_VDO_INDEX_ERROR, DM_VDO_COMPRESSION_ONLINE, 0, 1234}}, {(char *) "foo1234", DM_VDO_MODE_READ_ONLY, false, DM_VDO_INDEX_ERROR, DM_VDO_COMPRESSION_ONLINE, 0, 1234}},
{"f read-only - error online 0 1234", {"f read-only - error online 0 1234",
@ -136,7 +136,7 @@ static void _test_device_names_good(void *fixture)
static void _test_operating_mode_good(void *fixture) static void _test_operating_mode_good(void *fixture)
{ {
static struct example_good _es[] = { static const struct example_good _es[] = {
{"device-name recovering - error online 0 1234", {"device-name recovering - error online 0 1234",
{(char *) "device-name", DM_VDO_MODE_RECOVERING, false, DM_VDO_INDEX_ERROR, DM_VDO_COMPRESSION_ONLINE, 0, 1234}}, {(char *) "device-name", DM_VDO_MODE_RECOVERING, false, DM_VDO_INDEX_ERROR, DM_VDO_COMPRESSION_ONLINE, 0, 1234}},
{"device-name read-only - error online 0 1234", {"device-name read-only - error online 0 1234",
@ -150,7 +150,7 @@ static void _test_operating_mode_good(void *fixture)
static void _test_operating_mode_bad(void *fixture) static void _test_operating_mode_bad(void *fixture)
{ {
static struct example_bad _es[] = { static const struct example_bad _es[] = {
{"device-name investigating - error online 0 1234", {"device-name investigating - error online 0 1234",
"couldn't parse 'operating mode'"}}; "couldn't parse 'operating mode'"}};
@ -159,7 +159,7 @@ static void _test_operating_mode_bad(void *fixture)
static void _test_recovering_good(void *fixture) static void _test_recovering_good(void *fixture)
{ {
static struct example_good _es[] = { static const struct example_good _es[] = {
{"device-name recovering - error online 0 1234", {"device-name recovering - error online 0 1234",
{(char *) "device-name", DM_VDO_MODE_RECOVERING, false, DM_VDO_INDEX_ERROR, DM_VDO_COMPRESSION_ONLINE, 0, 1234}}, {(char *) "device-name", DM_VDO_MODE_RECOVERING, false, DM_VDO_INDEX_ERROR, DM_VDO_COMPRESSION_ONLINE, 0, 1234}},
{"device-name read-only recovering error online 0 1234", {"device-name read-only recovering error online 0 1234",
@ -171,7 +171,7 @@ static void _test_recovering_good(void *fixture)
static void _test_recovering_bad(void *fixture) static void _test_recovering_bad(void *fixture)
{ {
static struct example_bad _es[] = { static const struct example_bad _es[] = {
{"device-name normal fish error online 0 1234", {"device-name normal fish error online 0 1234",
"couldn't parse 'recovering'"}}; "couldn't parse 'recovering'"}};
@ -180,7 +180,7 @@ static void _test_recovering_bad(void *fixture)
static void _test_index_state_good(void *fixture) static void _test_index_state_good(void *fixture)
{ {
static struct example_good _es[] = { static const struct example_good _es[] = {
{"device-name recovering - error online 0 1234", {"device-name recovering - error online 0 1234",
{(char *) "device-name", DM_VDO_MODE_RECOVERING, false, DM_VDO_INDEX_ERROR, DM_VDO_COMPRESSION_ONLINE, 0, 1234}}, {(char *) "device-name", DM_VDO_MODE_RECOVERING, false, DM_VDO_INDEX_ERROR, DM_VDO_COMPRESSION_ONLINE, 0, 1234}},
{"device-name recovering - closed online 0 1234", {"device-name recovering - closed online 0 1234",
@ -202,7 +202,7 @@ static void _test_index_state_good(void *fixture)
static void _test_index_state_bad(void *fixture) static void _test_index_state_bad(void *fixture)
{ {
static struct example_bad _es[] = { static const struct example_bad _es[] = {
{"device-name normal - fish online 0 1234", {"device-name normal - fish online 0 1234",
"couldn't parse 'index state'"}}; "couldn't parse 'index state'"}};
@ -211,7 +211,7 @@ static void _test_index_state_bad(void *fixture)
static void _test_compression_state_good(void *fixture) static void _test_compression_state_good(void *fixture)
{ {
static struct example_good _es[] = { static const struct example_good _es[] = {
{"device-name recovering - error online 0 1234", {"device-name recovering - error online 0 1234",
{(char *) "device-name", DM_VDO_MODE_RECOVERING, false, DM_VDO_INDEX_ERROR, DM_VDO_COMPRESSION_ONLINE, 0, 1234}}, {(char *) "device-name", DM_VDO_MODE_RECOVERING, false, DM_VDO_INDEX_ERROR, DM_VDO_COMPRESSION_ONLINE, 0, 1234}},
{"device-name read-only - error offline 0 1234", {"device-name read-only - error offline 0 1234",
@ -223,7 +223,7 @@ static void _test_compression_state_good(void *fixture)
static void _test_compression_state_bad(void *fixture) static void _test_compression_state_bad(void *fixture)
{ {
static struct example_bad _es[] = { static const struct example_bad _es[] = {
{"device-name normal - error fish 0 1234", {"device-name normal - error fish 0 1234",
"couldn't parse 'compression state'"}}; "couldn't parse 'compression state'"}};
@ -232,7 +232,7 @@ static void _test_compression_state_bad(void *fixture)
static void _test_used_blocks_good(void *fixture) static void _test_used_blocks_good(void *fixture)
{ {
static struct example_good _es[] = { static const struct example_good _es[] = {
{"device-name recovering - error online 0 1234", {"device-name recovering - error online 0 1234",
{(char *) "device-name", DM_VDO_MODE_RECOVERING, false, DM_VDO_INDEX_ERROR, DM_VDO_COMPRESSION_ONLINE, 0, 1234}}, {(char *) "device-name", DM_VDO_MODE_RECOVERING, false, DM_VDO_INDEX_ERROR, DM_VDO_COMPRESSION_ONLINE, 0, 1234}},
{"device-name read-only - error offline 1 1234", {"device-name read-only - error offline 1 1234",
@ -248,7 +248,7 @@ static void _test_used_blocks_good(void *fixture)
static void _test_used_blocks_bad(void *fixture) static void _test_used_blocks_bad(void *fixture)
{ {
static struct example_bad _es[] = { static const struct example_bad _es[] = {
{"device-name normal - error online fish 1234", {"device-name normal - error online fish 1234",
"couldn't parse 'used blocks'"}}; "couldn't parse 'used blocks'"}};
@ -257,7 +257,7 @@ static void _test_used_blocks_bad(void *fixture)
static void _test_total_blocks_good(void *fixture) static void _test_total_blocks_good(void *fixture)
{ {
static struct example_good _es[] = { static const struct example_good _es[] = {
{"device-name recovering - error online 0 1234", {"device-name recovering - error online 0 1234",
{(char *) "device-name", DM_VDO_MODE_RECOVERING, false, DM_VDO_INDEX_ERROR, DM_VDO_COMPRESSION_ONLINE, 0, 1234}}, {(char *) "device-name", DM_VDO_MODE_RECOVERING, false, DM_VDO_INDEX_ERROR, DM_VDO_COMPRESSION_ONLINE, 0, 1234}},
{"device-name recovering - error online 0 1", {"device-name recovering - error online 0 1",
@ -271,7 +271,7 @@ static void _test_total_blocks_good(void *fixture)
static void _test_total_blocks_bad(void *fixture) static void _test_total_blocks_bad(void *fixture)
{ {
static struct example_bad _es[] = { static const struct example_bad _es[] = {
{"device-name normal - error online 0 fish", {"device-name normal - error online 0 fish",
"couldn't parse 'total blocks'"}}; "couldn't parse 'total blocks'"}};
@ -280,7 +280,7 @@ static void _test_total_blocks_bad(void *fixture)
static void _test_status_bad(void *fixture) static void _test_status_bad(void *fixture)
{ {
struct example_bad _bad[] = { static const struct example_bad _bad[] = {
{"", "couldn't get token for device"}, {"", "couldn't get token for device"},
{"device-name read-only - error online 0 1000 lksd", "too many tokens"} {"device-name read-only - error online 0 1000 lksd", "too many tokens"}
}; };