shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-03-10 16:58:47 +03:00
Code Releases Activity

Add FIXME for misuse in case of dm_event_mask enum.

Browse Source 
Using enum for bitmask is not proper solution here.
This commit is contained in:
Zdenek Kabelac 2012-02-27 11:46:25 +00:00
parent f380cd7d98
commit c57a9960b5
2 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
daemons/dmeventd/dmeventd.h
View File

@ -63,6 +63,7 @@ struct dm_event_fifos {
#define EXIT_CHDIR_FAILURE 7 #define EXIT_CHDIR_FAILURE 7
/* Implemented in libdevmapper-event.c, but not part of public API. */ /* Implemented in libdevmapper-event.c, but not part of public API. */
// FIXME misuse of bitmask as enum
int daemon_talk(struct dm_event_fifos *fifos, int daemon_talk(struct dm_event_fifos *fifos,
struct dm_event_daemon_message *msg, int cmd, struct dm_event_daemon_message *msg, int cmd,
const char *dso_name, const char *dev_name, const char *dso_name, const char *dev_name,

3
daemons/dmeventd/libdevmapper-event.h
View File

@ -82,6 +82,7 @@ void dm_event_handler_set_timeout(struct dm_event_handler *dmevh, int timeout);
/* /*
* Specify mask for events to monitor. * Specify mask for events to monitor.
*/ */
// FIXME misuse of bitmask as enum
void dm_event_handler_set_event_mask(struct dm_event_handler *dmevh, void dm_event_handler_set_event_mask(struct dm_event_handler *dmevh,
enum dm_event_mask evmask); enum dm_event_mask evmask);
@ -91,6 +92,7 @@ const char *dm_event_handler_get_uuid(const struct dm_event_handler *dmevh);
int dm_event_handler_get_major(const struct dm_event_handler *dmevh); int dm_event_handler_get_major(const struct dm_event_handler *dmevh);
int dm_event_handler_get_minor(const struct dm_event_handler *dmevh); int dm_event_handler_get_minor(const struct dm_event_handler *dmevh);
int dm_event_handler_get_timeout(const struct dm_event_handler *dmevh); int dm_event_handler_get_timeout(const struct dm_event_handler *dmevh);
// FIXME misuse of bitmask as enum
enum dm_event_mask dm_event_handler_get_event_mask(const struct dm_event_handler *dmevh); enum dm_event_mask dm_event_handler_get_event_mask(const struct dm_event_handler *dmevh);
/* FIXME Review interface (what about this next thing?) */ /* FIXME Review interface (what about this next thing?) */
@ -104,6 +106,7 @@ int dm_event_unregister_handler(const struct dm_event_handler *dmevh);
/* Prototypes for DSO interface, see dmeventd.c, struct dso_data for /* Prototypes for DSO interface, see dmeventd.c, struct dso_data for
detailed descriptions. */ detailed descriptions. */
// FIXME misuse of bitmask as enum
void process_event(struct dm_task *dmt, enum dm_event_mask evmask, void **user); void process_event(struct dm_task *dmt, enum dm_event_mask evmask, void **user);
int register_device(const char *device_name, const char *uuid, int major, int minor, void **user); int register_device(const char *device_name, const char *uuid, int major, int minor, void **user);
int unregister_device(const char *device_name, const char *uuid, int major, int unregister_device(const char *device_name, const char *uuid, int major,