diff --git a/WHATS_NEW b/WHATS_NEW index b113ec3d9..0eb5e81d5 100644 --- a/WHATS_NEW +++ b/WHATS_NEW @@ -1,5 +1,6 @@ Version 2.02.85 - =================================== + Fix incorrect tests for dm_snprintf() failure. Fix some unmatching sign comparation gcc warnings in the code. Allow lv_extend() to work on zero length intrinsically layered LVs. Keep the cache content when the exported vg buffer is matching. diff --git a/lib/metadata/lv_manip.c b/lib/metadata/lv_manip.c index bc3d42f14..0f7c4863b 100644 --- a/lib/metadata/lv_manip.c +++ b/lib/metadata/lv_manip.c @@ -2296,7 +2296,7 @@ static int _rename_sub_lv(struct cmd_context *cmd, log_error("Failed to allocate space for new name"); return 0; } - if (!dm_snprintf(new_name, len, "%s%s", lv_name_new, suffix)) { + if (dm_snprintf(new_name, len, "%s%s", lv_name_new, suffix) < 0) { log_error("Failed to create new name"); return 0; } diff --git a/lib/metadata/mirror.c b/lib/metadata/mirror.c index e4aa808c1..32b236cf4 100644 --- a/lib/metadata/mirror.c +++ b/lib/metadata/mirror.c @@ -1787,7 +1787,7 @@ static struct logical_volume *_set_up_mirror_log(struct cmd_context *cmd, } else if ((lv_name = strstr(lv->name, MIRROR_SYNC_LAYER))) { len = lv_name - lv->name + 1; if (!(tmp_name = alloca(len)) || - !dm_snprintf(tmp_name, len, "%s", lv->name)) { + (dm_snprintf(tmp_name, len, "%s", lv->name) < 0)) { log_error("mirror log name allocation failed"); return 0; } diff --git a/tools/lvconvert.c b/tools/lvconvert.c index 49d39cfd8..7f4960135 100644 --- a/tools/lvconvert.c +++ b/tools/lvconvert.c @@ -481,7 +481,7 @@ int lvconvert_poll(struct cmd_context *cmd, struct logical_volume *lv, if (!uuid || !lv_full_name) return_0; - if (!dm_snprintf(lv_full_name, len, "%s/%s", lv->vg->name, lv->name)) + if (dm_snprintf(lv_full_name, len, "%s/%s", lv->vg->name, lv->name) < 0) return_0; memcpy(uuid, &lv->lvid, sizeof(lv->lvid));