shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-03-10 16:58:47 +03:00
Code Releases Activity

Add vgcreate_params_set_defaults().

Browse Source 
Add function to set default vgcreate parameters based on existing VG or
internal defaults.  Should be no functional change.
This commit is contained in:
Dave Wysochanski 2009-11-01 20:02:32 +00:00
parent accb17389c
commit c6ea6bf5b7
4 changed files with 24 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
tools/toollib.c
View File

@ -1183,6 +1183,26 @@ int is_reserved_lvname(const char *name)
return rc;
}
void vgcreate_params_set_defaults(struct vgcreate_params *vp_def,
struct volume_group *vg)
{
if (vg) {
vp_def->vg_name = NULL;
vp_def->extent_size = vg->extent_size;
vp_def->max_pv = vg->max_pv;
vp_def->max_lv = vg->max_lv;
vp_def->alloc = vg->alloc;
vp_def->clustered = vg_is_clustered(vg);
} else {
vp_def->vg_name = NULL;
vp_def->extent_size = DEFAULT_EXTENT_SIZE * 2;
vp_def->max_pv = DEFAULT_MAX_PV;
vp_def->max_lv = DEFAULT_MAX_LV;
vp_def->alloc = DEFAULT_ALLOC_POLICY;
vp_def->clustered = DEFAULT_CLUSTERED;
}
}
/*
* Set members of struct vgcreate_params from cmdline.
* Do preliminary validation with arg_*() interface.

2
tools/toollib.h
View File

@ -99,6 +99,8 @@ struct dm_list *clone_pv_list(struct dm_pool *mem, struct dm_list *pvs);
int apply_lvname_restrictions(const char *name);
int is_reserved_lvname(const char *name);
void vgcreate_params_set_defaults(struct vgcreate_params *vp_def,
struct volume_group *vg);
int fill_vg_create_params(struct cmd_context *cmd,
char *vg_name, struct vgcreate_params *vp_new,
struct vgcreate_params *vp_def);

7
tools/vgcreate.c
View File

@ -45,12 +45,7 @@ int vgcreate(struct cmd_context *cmd, int argc, char **argv)
return EINVALID_CMD_LINE;
}
vp_def.vg_name = NULL;
vp_def.extent_size = DEFAULT_EXTENT_SIZE * 2;
vp_def.max_pv = DEFAULT_MAX_PV;
vp_def.max_lv = DEFAULT_MAX_LV;
vp_def.alloc = DEFAULT_ALLOC_POLICY;
vp_def.clustered = DEFAULT_CLUSTERED;
vgcreate_params_set_defaults(&vp_def, NULL);
if (fill_vg_create_params(cmd, vg_name, &vp_new, &vp_def))
return EINVALID_CMD_LINE;

8
tools/vgsplit.c
View File

@ -366,13 +366,7 @@ int vgsplit(struct cmd_context *cmd, int argc, char **argv)
if (!vgs_are_compatible(cmd, vg_from,vg_to))
goto_bad;
} else {
vp_def.vg_name = NULL;
vp_def.extent_size = vg_from->extent_size;
vp_def.max_pv = vg_from->max_pv;
vp_def.max_lv = vg_from->max_lv;
vp_def.alloc = vg_from->alloc;
vp_def.clustered = vg_is_clustered(vg_from);
vgcreate_params_set_defaults(&vp_def, vg_from);
if (fill_vg_create_params(cmd, vg_name_to, &vp_new, &vp_def)) {
r = EINVALID_CMD_LINE;
goto_bad;