shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-03-28 02:50:41 +03:00
Code Releases Activity

lvchange: resync attempts on raid0 cause segfaults

Browse Source 
Resync attempts on raid0/raid0_meta via 'lvchange --resync ...'
cause segfaults.

'lvchange --syncaction ...' doesn't get rejected either.

Prohibit both on raid0/raid0_meta LVs.

- resolves rhbz1354656
This commit is contained in:
Heinz Mauelshagen 2016-07-12 17:20:38 +02:00
parent dcbcc65dc2
commit c77c59f3d9
1 changed files with 14 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
tools/lvchange.c
View File

@ -326,8 +326,9 @@ static int _lvchange_resync(struct cmd_context *cmd, struct logical_volume *lv)
dm_list_init(&device_list);
if (!seg_is_mirror(seg) && !seg_is_raid(seg)) {
log_error("Unable to resync %s. It is not RAID or mirrored.",
if (seg_is_any_raid0(seg) ||
(!seg_is_mirror(seg) && !seg_is_raid(seg))) {
log_error("Unable to resync %s. It is not RAID4/5/6/10 or mirrored.",
display_lvname(lv));
return 0;
}
@ -1179,9 +1180,17 @@ static int _lvchange_single(struct cmd_context *cmd, struct logical_volume *lv,
!_lvchange_resync(cmd, lv))
return_ECMD_FAILED;
if (arg_is_set(cmd, syncaction_ARG) &&
!lv_raid_message(lv, arg_str_value(cmd, syncaction_ARG, NULL)))
return_ECMD_FAILED;
if (arg_is_set(cmd, syncaction_ARG)) {
struct lv_segment *seg = first_seg(lv);
if (seg_is_any_raid0(seg)) {
log_error("Unable to sync raid0 LV %s.", display_lvname(lv));
return_ECMD_FAILED;
}
if (!lv_raid_message(lv, arg_str_value(cmd, syncaction_ARG, NULL)))
return_ECMD_FAILED;
}
/* activation change */
if (arg_is_set(cmd, activate_ARG)) {