shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

scan: wipe filters when dropping scanned data

Browse Source 
Fix clearing persistent filter state when clearing all
the state from a label_scan.

label_scan reads devs and saves info in bcache, lvmcache,
and in the persistent filter.  In some uncommon cases, an
lvm command wants to clear all info from a prior label_scan,
and repeat label_scan from scratch.  In these cases, info
in lvmcache, bcache and the persistent filter all need to
be cleared before repeating label_scan.

By missing the persistent filter wiping, outdated persistent
filter info, from a prior label_scan, could cause lvm to
incorrectly filter devices that change between polling intervals.
(i.e. if the device changes in such a way that the filtering
results change.)

A case where lvm wants to do multiple label_scans is a
polling command (like lvconvert --merge), when lvmpolld
has been disabled, so that the command itself needs to
to do repeated polling checks.
This commit is contained in:
David Teigland 2021-02-10 14:06:58 -06:00
parent f49bedc029
commit c94d78f068
1 changed files with 1 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
lib/label/label.c
View File

@ -707,19 +707,6 @@ static int _scan_list(struct cmd_context *cmd, struct dev_filter *f,
if (!rem_prefetches) if (!rem_prefetches)
break; break;
/* FIXME: figure better solution to avoid opening DM we shouldn't open */
if (dm_is_dm_major(MAJOR(devl->dev->dev)) &&
!device_is_usable(devl->dev, (struct dev_usable_check_params) {
.check_blocked = 1,
.check_suspended = ignore_suspended_devices(),
.check_reserved = 1,
.check_error_target = 1,
})) {
log_debug_devs("Scan skips unusuable DM device %s.", dev_name(devl->dev));
dm_list_del(&devl->list);
continue;
}
if (!_in_bcache(devl->dev)) { if (!_in_bcache(devl->dev)) {
if (!_scan_dev_open(devl->dev)) { if (!_scan_dev_open(devl->dev)) {
log_debug_devs("Scan failed to open %s.", dev_name(devl->dev)); log_debug_devs("Scan failed to open %s.", dev_name(devl->dev));
@ -1432,6 +1419,7 @@ void label_scan_drop(struct cmd_context *cmd)
return; return;
while ((dev = dev_iter_get(cmd, iter))) { while ((dev = dev_iter_get(cmd, iter))) {
cmd->filter->wipe(cmd, cmd->filter, dev, NULL);
if (_in_bcache(dev)) if (_in_bcache(dev))
_scan_dev_close(dev); _scan_dev_close(dev);
} }