shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

scan: md metadata version 0.90 is at the end of disk

Browse Source 
commit de28637
  scan: use full md filter when md 1.0 devices are present

missed the fact that md superblock version 0.90 also puts
metadata at the end of the device, so the full md filter
needs to be used when either 0.90 or 1.0 is present.
This commit is contained in:
Peter Rajnoha 2018-11-29 12:35:54 -06:00 committed by David Teigland
parent cd0fb0846d
commit cb04b84c79
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/device/dev-md.c
View File

@ -422,7 +422,7 @@ int dev_is_md_with_end_superblock(struct dev_types *dt, struct device *dev)
log_very_verbose("Device %s %s is %s.", log_very_verbose("Device %s %s is %s.",
dev_name(dev), attribute, version_string); dev_name(dev), attribute, version_string);
if (!strcmp(version_string, "1.0")) if (!strcmp(version_string, "1.0") || !strcmp(version_string, "0.90"))
return 1; return 1;
return 0; return 0;
} }

6
lib/filters/filter-md.c
View File

@ -46,7 +46,7 @@
* 3. use udev to detect components * 3. use udev to detect components
* *
* mode 1 will not detect and exclude components of md devices * mode 1 will not detect and exclude components of md devices
* that use superblock version 1.0 which is at the end of the device. * that use superblock version 0.9 or 1.0 which is at the end of the device.
* *
* mode 2 will detect these, but mode 2 doubles the i/o done by label * mode 2 will detect these, but mode 2 doubles the i/o done by label
* scan, since there's a read at both the start and end of every device. * scan, since there's a read at both the start and end of every device.
@ -59,11 +59,11 @@
* *
* - the command is pvcreate/vgcreate/vgextend, which format new * - the command is pvcreate/vgcreate/vgextend, which format new
* devices, and if the user ran these commands on a component * devices, and if the user ran these commands on a component
* device of an md device 1.0, then it would cause problems. * device of an md device 0.9 or 1.0, then it would cause problems.
* FIXME: this would only really need to scan the end of the * FIXME: this would only really need to scan the end of the
* devices being formatted, not all devices. * devices being formatted, not all devices.
* *
* - it sees an md device on the system using version 1.0. * - it sees an md device on the system using version 0.9 or 1.0.
* The point of this is just to avoid displaying md components * The point of this is just to avoid displaying md components
* from the 'pvs' command. * from the 'pvs' command.
* FIXME: the cost (double i/o) may not be worth the benefit * FIXME: the cost (double i/o) may not be worth the benefit