shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

libdm: improve comments in stats grouping functions

Browse Source 
Add more detailed comments to dm_stats_create_group() and
_stats_group_check_overlap().
This commit is contained in:
Bryn M. Reeves 2016-07-08 11:05:38 +01:00
parent 059a383cf8
commit cc4f036d36
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
libdm/libdm-stats.c
View File

@ -3686,6 +3686,7 @@ static int _stats_group_check_overlap(const struct dm_stats *dms,
return 0; return 0;
} }
/* build a table of extents in order of region_id */
for (id = dm_bit_get_first(regions); id >= 0; for (id = dm_bit_get_first(regions); id >= 0;
id = dm_bit_get_next(regions, id)) { id = dm_bit_get_next(regions, id)) {
dm_list_init(&map[i].list); dm_list_init(&map[i].list);
@ -3695,6 +3696,7 @@ static int _stats_group_check_overlap(const struct dm_stats *dms,
i++; i++;
} }
/* sort by extent.start */
qsort(map, count, sizeof(*map), _extent_start_compare); qsort(map, count, sizeof(*map), _extent_start_compare);
for (i = 0; i < count; i++) for (i = 0; i < count; i++)
@ -3724,6 +3726,7 @@ merge:
overlap = merged = 1; overlap = merged = 1;
} }
} }
/* continue until no merge candidates remain */
if (merged) if (merged)
goto merge; goto merge;
@ -3757,6 +3760,11 @@ int dm_stats_create_group(struct dm_stats *dms, const char *members,
goto bad; goto bad;
} }
/*
* Check that each region_id in the bitmap meets the group
* constraints: present, not already grouped, and if any
* histogram is present that they all have the same bounds.
*/
for (i = dm_bit_get_first(regions); i >= 0; for (i = dm_bit_get_first(regions); i >= 0;
i = dm_bit_get_next(regions, i)) { i = dm_bit_get_next(regions, i)) {
if (!dm_stats_region_present(dms, i)) { if (!dm_stats_region_present(dms, i)) {
@ -3828,9 +3836,11 @@ int dm_stats_delete_group(struct dm_stats *dms, uint64_t group_id,
} }
} }
/* clear group and mark as not present */
_stats_clear_group_regions(dms, group_id); _stats_clear_group_regions(dms, group_id);
_stats_group_destroy(&dms->groups[group_id]); _stats_group_destroy(&dms->groups[group_id]);
/* delete leader or clear aux_data */
if (remove_regions) if (remove_regions)
return dm_stats_delete_region(dms, group_id); return dm_stats_delete_region(dms, group_id);
else if (!_stats_set_aux(dms, group_id, leader->aux_data)) else if (!_stats_set_aux(dms, group_id, leader->aux_data))