From cc83091cd51ac485cd5b0fd47369af4529a29a7a Mon Sep 17 00:00:00 2001 From: Zdenek Kabelac Date: Fri, 2 Nov 2018 21:50:29 +0100 Subject: [PATCH] cov: add missing check for dm_strncpy --- lib/activate/dev_manager.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/activate/dev_manager.c b/lib/activate/dev_manager.c index 67a49bef3..aaf113fd9 100644 --- a/lib/activate/dev_manager.c +++ b/lib/activate/dev_manager.c @@ -1916,7 +1916,11 @@ static int _check_holder(struct dev_manager *dm, struct dm_tree *dtree, if (!strncmp(uuid, (char*)&lv->vg->id, sizeof(lv->vg->id)) && !dm_tree_find_node_by_uuid(dtree, uuid)) { - dm_strncpy((char*)&id, uuid, 2 * sizeof(struct id) + 1); + if (!dm_strncpy((char*)&id, uuid, 2 * sizeof(struct id) + 1)) { + log_error(INTERNAL_ERROR "Too long UUID %s in VG %s.", + uuid, lv->vg->name); + goto out; + } /* If UUID is not yet in dtree, look for matching LV */ if (!(lv_det = find_lv_in_vg_by_lvid(lv->vg, &id))) {