1
0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00

Fix vgreduce --removemissing failure exit code.

This commit is contained in:
Milan Broz 2009-04-22 17:00:28 +00:00
parent efa62ff443
commit cd978f74da
3 changed files with 6 additions and 4 deletions

View File

@ -1,5 +1,6 @@
Version 2.02.46 - Version 2.02.46 -
================================ ================================
Fix vgreduce --removemissing failure exit code.
Fix remote metadata backup for clvmd. Fix remote metadata backup for clvmd.
Alloc PV internal structure from VG mempool if possible. Alloc PV internal structure from VG mempool if possible.
Fix metadata backup to run after vg_commit always. Fix metadata backup to run after vg_commit always.

View File

@ -6,7 +6,6 @@ lvcreate -m 1 -l 1 -n mirror $vg
lvchange -a n $vg/mirror lvchange -a n $vg/mirror
disable_dev $dev1 disable_dev $dev1
# FIXME should this return an error code due to that big fat WARNING? not vgreduce --removemissing $vg
vgreduce --removemissing $vg
not lvchange -v -a y $vg/mirror not lvchange -v -a y $vg/mirror
lvchange -v --partial -a y $vg/mirror lvchange -v --partial -a y $vg/mirror

View File

@ -556,11 +556,13 @@ int vgreduce(struct cmd_context *cmd, int argc, char **argv)
} }
backup(vg); backup(vg);
if (fixed) if (fixed) {
log_print("Wrote out consistent volume group %s", log_print("Wrote out consistent volume group %s",
vg_name); vg_name);
ret = ECMD_PROCESSED; ret = ECMD_PROCESSED;
} else
ret = ECMD_FAILED;
} else { } else {
if (!vg_check_status(vg, EXPORTED_VG | LVM_WRITE | RESIZEABLE_VG)) if (!vg_check_status(vg, EXPORTED_VG | LVM_WRITE | RESIZEABLE_VG))
goto out; goto out;