shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-22 17:35:59 +03:00
Code Releases Activity

pvresize: Do not use pv_read (get the PV from orphan VG).

Browse Source
This commit is contained in:
Petr Rockai 2013-02-19 01:54:34 +01:00
parent d838501c44
commit d17cbf112b
2 changed files with 18 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/metadata/pv_manip.c
View File

@ -513,7 +513,7 @@ int pv_resize(struct physical_volume *pv,
/* pv->pe_count is 0 now! We need to recalculate! */ /* pv->pe_count is 0 now! We need to recalculate! */
/* If there's a VG, calculate new PE count value. */ /* If there's a VG, calculate new PE count value. */
if (vg) { if (vg && !is_orphan_vg(vg->name)) {
/* FIXME: Maybe PE calculation should go into pv->fmt->resize? /* FIXME: Maybe PE calculation should go into pv->fmt->resize?
(like it is for pv->fmt->setup) */ (like it is for pv->fmt->setup) */
if (!(new_pe_count = pv_size(pv) / vg->extent_size)) { if (!(new_pe_count = pv_size(pv) / vg->extent_size)) {

15
tools/pvresize.c
View File

@ -37,18 +37,6 @@ static int _pv_resize_single(struct cmd_context *cmd,
struct volume_group *old_vg = vg; struct volume_group *old_vg = vg;
int vg_needs_pv_write = 0; int vg_needs_pv_write = 0;
if (is_orphan_vg(vg_name)) {
if (!lock_vol(cmd, vg_name, LCK_VG_WRITE)) {
log_error("Can't get lock for orphans");
return 0;
}
if (!(pv = pv_read(cmd, pv_name, 1, 0))) {
unlock_vg(cmd, vg_name);
log_error("Unable to read PV \"%s\"", pv_name);
return 0;
}
} else {
vg = vg_read_for_update(cmd, vg_name, NULL, 0); vg = vg_read_for_update(cmd, vg_name, NULL, 0);
if (vg_read_error(vg)) { if (vg_read_error(vg)) {
@ -68,7 +56,6 @@ static int _pv_resize_single(struct cmd_context *cmd,
if (!archive(vg)) if (!archive(vg))
goto out; goto out;
}
if (!(pv->fmt->features & FMT_RESIZE_PV)) { if (!(pv->fmt->features & FMT_RESIZE_PV)) {
log_error("Physical volume %s format does not support resizing.", log_error("Physical volume %s format does not support resizing.",
@ -126,8 +113,6 @@ out:
log_error("Use pvcreate and vgcfgrestore " log_error("Use pvcreate and vgcfgrestore "
"to repair from archived metadata."); "to repair from archived metadata.");
unlock_vg(cmd, vg_name); unlock_vg(cmd, vg_name);
if (is_orphan_vg(vg_name))
free_pv_fid(pv);
if (!old_vg) if (!old_vg)
release_vg(vg); release_vg(vg);
return r; return r;