shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

lvconvert: --trackchanges requires --splitmirrors 1

Browse Source
This commit is contained in:
Alasdair G Kergon 2016-07-25 21:15:25 +01:00
parent d0e15b86b5
commit d180bf6311
2 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
WHATS_NEW
View File

@ -1,6 +1,6 @@
Version 2.02.162 - Version 2.02.162 -
================================= =================================
Improve lvconvert --trackchanges validation to require --splitmirrors. Improve lvconvert --trackchanges validation to require --splitmirrors 1.
Add note about lastlog built-in command to lvm man page. Add note about lastlog built-in command to lvm man page.
Fix unrecognised segtype flag message. Fix unrecognised segtype flag message.
lvconvert reuse cachepool metadade now ONLY with -Zn and clear otherwise. lvconvert reuse cachepool metadade now ONLY with -Zn and clear otherwise.

10
tools/lvconvert.c
View File

@ -1894,6 +1894,13 @@ static int _lvconvert_raid(struct logical_volume *lv, struct lvconvert_params *l
lp->keep_mimages ? "split" : "reduce"); lp->keep_mimages ? "split" : "reduce");
return 0; return 0;
} }
/* --trackchanges requires --splitmirrors which always has SIGN_MINUS */
if (lp->track_changes && lp->mirrors != 1) {
log_error("Exactly one image must be split off from %s when tracking changes.",
display_lvname(lv));
return 0;
}
} }
if (lp->merge_mirror) if (lp->merge_mirror)
@ -1903,8 +1910,7 @@ static int _lvconvert_raid(struct logical_volume *lv, struct lvconvert_params *l
return lv_raid_split_and_track(lv, lp->pvh); return lv_raid_split_and_track(lv, lp->pvh);
if (lp->keep_mimages) if (lp->keep_mimages)
return lv_raid_split(lv, lp->lv_split_name, return lv_raid_split(lv, lp->lv_split_name, image_count, lp->pvh);
image_count, lp->pvh);
if (lp->mirrors_supplied) if (lp->mirrors_supplied)
return lv_raid_change_image_count(lv, image_count, lp->pvh); return lv_raid_change_image_count(lv, image_count, lp->pvh);