shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-01-03 05:18:29 +03:00
Code Releases Activity

lvconvert: add FIXME

Browse Source 
operations are no longer identified correctly.
This commit is contained in:
David Teigland 2016-08-04 11:40:27 -05:00
parent 4a15abe865
commit d1a25fe597
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
tools/lvconvert.c
View File

@ -4337,7 +4337,14 @@ static int _convert_striped(struct cmd_context *cmd, struct logical_volume *lv,
* for each arg_is_set(operation)
* _convert_lvtype_operation();
*
* FIXME: this code (identifying/routing each unique operation through
* _convert_lvtype_op) was designed to work based on the new type that
* the user entered after --type, not the final segment type in lp->type_str.
* Sometimes the two differ because tricks are played with lp->type_str.
* So, when the use of arg_type_str(type_ARG) here was replaced with
* lp->type_str, some commands are no longer identified/routed correctly.
*/
static int _lvconvert(struct cmd_context *cmd, struct logical_volume *lv,
struct lvconvert_params *lp)
{