shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-01-03 05:18:29 +03:00
Code Releases Activity

Refactor vgsplit - create _vgsplit_from function to open source vg.

Browse Source 
Should be no functional change and allows future reorder of source and dest
vgs.


Author: Dave Wysochanski <dwysocha@redhat.com>
This commit is contained in:
Dave Wysochanski 2009-09-02 21:26:50 +00:00
parent 501fda8056
commit d1c45aa74f
1 changed files with 23 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
tools/vgsplit.c
View File

@ -243,6 +243,27 @@ static struct volume_group *_vgsplit_to(struct cmd_context *cmd,
return vg_to; return vg_to;
} }
/*
* Open the source of the vgsplit operation.
* Returns
* - non-NULL: VG handle w/VG lock held
* - NULL: no VG lock held
*/
static struct volume_group *_vgsplit_from(struct cmd_context *cmd,
const char *vg_name_from)
{
struct volume_group *vg_from;
log_verbose("Checking for volume group \"%s\"", vg_name_from);
vg_from = vg_read_for_update(cmd, vg_name_from, NULL, 0);
if (vg_read_error(vg_from)) {
vg_release(vg_from);
return NULL;
}
return vg_from;
}
/* /*
* Has the user given an option related to a new vg as the split destination? * Has the user given an option related to a new vg as the split destination?
*/ */
@ -293,13 +314,9 @@ int vgsplit(struct cmd_context *cmd, int argc, char **argv)
return ECMD_FAILED; return ECMD_FAILED;
} }
log_verbose("Checking for volume group \"%s\"", vg_name_from); vg_from = _vgsplit_from(cmd, vg_name_from);
if (!vg_from)
vg_from = vg_read_for_update(cmd, vg_name_from, NULL, 0);
if (vg_read_error(vg_from)) {
vg_release(vg_from);
return ECMD_FAILED; return ECMD_FAILED;
}
/* /*
* Set metadata format of original VG. * Set metadata format of original VG.