From d6ac039b65a371caeabb1bf2a191e609ed2cd9f8 Mon Sep 17 00:00:00 2001 From: Zdenek Kabelac Date: Thu, 30 Jan 2020 12:43:53 +0100 Subject: [PATCH] cov: widen before calculating min_chunk_size Although we expect min_chunk_size to be 32bit value, for large size of caches it might be useful to do calcs 64bit. So to avoid doing shift as signed 32bit - use unsigned 64bit from the start. --- lib/metadata/cache_manip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/metadata/cache_manip.c b/lib/metadata/cache_manip.c index 5613a2224..49b385052 100644 --- a/lib/metadata/cache_manip.c +++ b/lib/metadata/cache_manip.c @@ -222,7 +222,7 @@ int update_cache_pool_params(struct cmd_context *cmd, *chunk_size = get_default_allocation_cache_pool_chunk_size_CFG(cmd, profile); /* Use power-of-2 for min chunk size when unspecified */ - min_chunk_size = 1 << (32 - clz(min_chunk_size - 1)); + min_chunk_size = UINT64_C(1) << (32 - clz(min_chunk_size - 1)); } if (*chunk_size < min_chunk_size) { /*