shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-01-03 05:18:29 +03:00
Code Releases Activity

cleanup: correcting tracing

Browse Source 
Use log_error for real error.
This commit is contained in:
Zdenek Kabelac 2014-11-03 12:52:24 +01:00
parent d574072dd8
commit d6c5445bea
2 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/activate/dev_manager.c
View File

@ -558,7 +558,7 @@ static const struct dm_info *_cached_info(struct dm_pool *mem,
} }
if (!(dnode = dm_tree_find_node_by_uuid(dtree, dlid))) if (!(dnode = dm_tree_find_node_by_uuid(dtree, dlid)))
goto out; goto_out;
if (!(dinfo = dm_tree_node_get_info(dnode))) { if (!(dinfo = dm_tree_node_get_info(dnode))) {
log_error("Failed to get info from tree node for %s.", lv->name); log_error("Failed to get info from tree node for %s.", lv->name);
@ -1099,7 +1099,7 @@ int dev_manager_raid_status(struct dev_manager *dm,
dm_get_next_target(dmt, NULL, &start, &length, &type, &params); dm_get_next_target(dmt, NULL, &start, &length, &type, &params);
if (!type || strcmp(type, "raid")) { if (!type || strcmp(type, "raid")) {
log_debug("Expected raid segment type but got %s instead", log_error("Expected raid segment type but got %s instead",
type ? type : "NULL"); type ? type : "NULL");
goto out; goto out;
} }
@ -1193,7 +1193,7 @@ int dev_manager_cache_status(struct dev_manager *dm,
dm_get_next_target(dmt, NULL, &start, &length, &type, &params); dm_get_next_target(dmt, NULL, &start, &length, &type, &params);
if (!type || strcmp(type, "cache")) { if (!type || strcmp(type, "cache")) {
log_debug("Expected cache segment type but got %s instead", log_error("Expected cache segment type but got %s instead",
type ? type : "NULL"); type ? type : "NULL");
goto out; goto out;
} }

5
lib/metadata/cache_manip.c
View File

@ -241,7 +241,8 @@ int lv_cache_remove(struct logical_volume *cache_lv)
struct lv_status_cache *status; struct lv_status_cache *status;
if (!lv_is_cache(cache_lv)) { if (!lv_is_cache(cache_lv)) {
log_error(INTERNAL_ERROR "LV %s is not cached.", cache_lv->name); log_error(INTERNAL_ERROR "LV %s is not cache volume.",
display_lvname(cache_lv));
return 0; return 0;
} }
@ -291,7 +292,7 @@ int lv_cache_remove(struct logical_volume *cache_lv)
/* update the kernel to put the cleaner policy in place */ /* update the kernel to put the cleaner policy in place */
if (!lv_update_and_reload(cache_lv)) if (!lv_update_and_reload(cache_lv))
return_0; return_0;
} }
//FIXME: use polling to do this... //FIXME: use polling to do this...