shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-01-02 01:18:26 +03:00
Code Releases Activity

cleanup: put all tests within switch

Browse Source 
No reason to check for VALID in extra if.
This commit is contained in:
Zdenek Kabelac 2014-04-28 10:17:30 +02:00
parent d1aba7ccf6
commit d8214cb154
1 changed files with 25 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

49
lib/display/display.c
View File

@ -840,30 +840,31 @@ void display_tags(const struct cmd_context *cmd)
void display_name_error(name_error_t name_error)
{
if (name_error != NAME_VALID) {
switch(name_error) {
case NAME_INVALID_EMPTY:
log_error("Name is zero length");
break;
case NAME_INVALID_HYPEN:
log_error("Name cannot start with hyphen");
break;
case NAME_INVALID_DOTS:
log_error("Name starts with . or .. and has no "
"following character(s)");
break;
case NAME_INVALID_CHARSET:
log_error("Name contains invalid character, valid set includes: "
"[a-zA-Z0-9.-_+]");
break;
case NAME_INVALID_LENGTH:
/* Report that name length -1 to accommodate nul*/
log_error("Name length exceeds maximum limit of %d", (NAME_LEN -1));
break;
default:
log_error("Unknown error %d on name validation", name_error);
break;
}
switch(name_error) {
case NAME_VALID:
/* Valid name */
break;
case NAME_INVALID_EMPTY:
log_error("Name is zero length.");
break;
case NAME_INVALID_HYPEN:
log_error("Name cannot start with hyphen.");
break;
case NAME_INVALID_DOTS:
log_error("Name starts with . or .. and has no "
"following character(s).");
break;
case NAME_INVALID_CHARSET:
log_error("Name contains invalid character, valid set includes: "
"[a-zA-Z0-9.-_+].");
break;
case NAME_INVALID_LENGTH:
/* Report that name length - 1 to accommodate nul*/
log_error("Name length exceeds maximum limit of %d.", (NAME_LEN - 1));
break;
default:
log_error(INTERNAL_ERROR "Unknown error %d on name validation.", name_error);
break;
}
}