From d8bdc7af3749cbdc9110057daa837d2fe19dcf72 Mon Sep 17 00:00:00 2001 From: Zdenek Kabelac Date: Mon, 25 Apr 2016 13:40:26 +0200 Subject: [PATCH] lvchange: fix return code We already opened VG for this - so not an invalid cmdline. --- WHATS_NEW | 1 + tools/lvchange.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/WHATS_NEW b/WHATS_NEW index b6d9fd2ff..d55745994 100644 --- a/WHATS_NEW +++ b/WHATS_NEW @@ -1,5 +1,6 @@ Version 2.02.152 - ================================== + Use failed command return code when lvchanging read-only volume. Show creation transaction_id and zeroing state of pool with thin volume. Stop checking for dm_cache_mq policy with cache target 1.9 (alias to smq). Check first /sys/module/dm_* dir existance before using modprobe. diff --git a/tools/lvchange.c b/tools/lvchange.c index 631d7f860..0f46e2c8f 100644 --- a/tools/lvchange.c +++ b/tools/lvchange.c @@ -915,7 +915,7 @@ static int _lvchange_single(struct cmd_context *cmd, struct logical_volume *lv, arg_count(cmd, metadataprofile_ARG))) { log_error("Only -a permitted with read-only volume " "group \"%s\"", lv->vg->name); - return EINVALID_CMD_LINE; + return ECMD_FAILED; } if (lv_is_origin(lv) && !lv_is_thin_volume(lv) &&