shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-03-11 20:58:50 +03:00
Code Releases Activity

o Tidy in dm-fs.c

Browse Source 
o Magic number is really magic
 o Check on directory names
This commit is contained in:
Steven Whitehouse 2001-09-13 19:41:46 +00:00
parent 19e1b15feb
commit d9c3226ee2
1 changed files with 22 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
driver/device-mapper/dm-fs.c
View File

@ -18,8 +18,8 @@
#include "dm.h" #include "dm.h"
/* some random number */ /* some magic number */
#define DM_MAGIC 0x211271 #define DM_MAGIC 0x444D4653
static struct super_operations dm_ops; static struct super_operations dm_ops;
static struct address_space_operations dm_aops; static struct address_space_operations dm_aops;
@ -46,6 +46,17 @@ struct line_c {
struct file *out; struct file *out;
}; };
static int is_identifier(char *str, int len)
{
while(len--) {
if (!isalnum(*str) || *str != '_')
return 0;
str++;
}
return 1;
}
/* /*
* Grabs lines one at a time from the table file. * Grabs lines one at a time from the table file.
*/ */
@ -269,7 +280,8 @@ struct inode *_get_inode(struct super_block *sb, int mode, int dev)
inode->i_atime = inode->i_mtime = inode->i_atime = inode->i_mtime =
inode->i_ctime = CURRENT_TIME; inode->i_ctime = CURRENT_TIME;
switch (mode & S_IFMT) { switch (mode & S_IFMT) {
default: case S_IFBLK:
case S_IFCHR:
init_special_inode(inode, mode, dev); init_special_inode(inode, mode, dev);
break; break;
case S_IFREG: case S_IFREG:
@ -282,6 +294,8 @@ struct inode *_get_inode(struct super_block *sb, int mode, int dev)
case S_IFLNK: case S_IFLNK:
inode->i_op = &page_symlink_inode_operations; inode->i_op = &page_symlink_inode_operations;
break; break;
default:
make_bad_inode(inode);
} }
} }
return inode; return inode;
@ -309,6 +323,9 @@ static int _mkdir(struct inode * dir, struct dentry * dentry, int mode)
int r; int r;
const char *name = (const char *) dentry->d_name.name; const char *name = (const char *) dentry->d_name.name;
if (!is_identifier(name, dentry->d_name.len))
return -EPERM; /* or EINVAL ? */
r = dm_create(name, -1); r = dm_create(name, -1);
if (r) if (r)
return r; return r;
@ -346,7 +363,7 @@ static int _create(struct inode *dir, struct dentry *dentry, int mode)
return 0; return 0;
} }
static inline int _positive(struct dentry *dentry) static inline int positive(struct dentry *dentry)
{ {
return dentry->d_inode && !d_unhashed(dentry); return dentry->d_inode && !d_unhashed(dentry);
} }
@ -369,7 +386,7 @@ static int _empty(struct dentry *dentry)
while (list != &dentry->d_subdirs) { while (list != &dentry->d_subdirs) {
struct dentry *de = list_entry(list, struct dentry, d_child); struct dentry *de = list_entry(list, struct dentry, d_child);
if (_positive(de)) { if (positive(de)) {
spin_unlock(&dcache_lock); spin_unlock(&dcache_lock);
return 0; return 0;
} }