From dac990ae03f9517e050f8ea3a55529e944c60f4f Mon Sep 17 00:00:00 2001 From: Zdenek Kabelac Date: Thu, 4 Mar 2021 18:17:03 +0100 Subject: [PATCH] cleanup: avoid allocating memory for hash key Hash always allocates its own copy of the key so avoid this extra uuid copy. --- lib/format_text/export.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/format_text/export.c b/lib/format_text/export.c index 7a95bdba4..cdae8bc87 100644 --- a/lib/format_text/export.c +++ b/lib/format_text/export.c @@ -955,7 +955,8 @@ static int _build_pv_names(struct formatter *f, struct volume_group *vg) int count = 0; struct pv_list *pvl; struct physical_volume *pv; - char buffer[32], *uuid, *name; + char buffer[32], *name; + char uuid[64]; if (!(f->mem = dm_pool_create("text pv_names", 512))) return_0; @@ -973,8 +974,7 @@ static int _build_pv_names(struct formatter *f, struct volume_group *vg) if (!(name = dm_pool_strdup(f->mem, buffer))) return_0; - if (!(uuid = dm_pool_zalloc(f->mem, 64)) || - !id_write_format(&pv->id, uuid, 64)) + if (!id_write_format(&pv->id, uuid, sizeof(uuid))) return_0; if (!dm_hash_insert(f->pv_names, uuid, name))