From dc5190de74893ede7d3170b861ce8ae9327ecfae Mon Sep 17 00:00:00 2001 From: Tony Asleson Date: Mon, 4 May 2015 15:20:55 -0500 Subject: [PATCH] lvm2app: Correct missing string properties Synopsis: STR_LIST needs to be treated as STR for properties. For any lvm property that was internally 'typed' as a string list we were failing to return a string in the property API. This was due to the fact that for the properties to work the value needs to either be evaulated as a string or a number. This change corrects the macro used to build the memory array of structures so that the string bitfield is set as needed to ensure that the value is a string. https://bugzilla.redhat.com/show_bug.cgi?id=1139920 Signed-off-by: Tony Asleson --- lib/properties/prop_common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/properties/prop_common.h b/lib/properties/prop_common.h index 0b1678d38..9cc963aba 100644 --- a/lib/properties/prop_common.h +++ b/lib/properties/prop_common.h @@ -132,6 +132,6 @@ static int _ ## NAME ## _get (const void *obj, struct lvm_property_type *prop) \ #define FIELD_MODIFIABLE 0x00000001 #define FIELD(type, strct, field_type, head, field, width, fn, id, desc, settable) \ - { type, #id, settable, field_type == STR, ((field_type == NUM) || (field_type == BIN) || (field_type == SIZ) || (field_type == PCT) || (field_type == SNUM)), ((field_type == SNUM) || (field_type == PCT)), { .integer = 0 }, _ ## id ## _get, _ ## id ## _set }, + { type, #id, settable, (field_type == STR || field_type == STR_LIST), ((field_type == NUM) || (field_type == BIN) || (field_type == SIZ) || (field_type == PCT) || (field_type == SNUM)), ((field_type == SNUM) || (field_type == PCT)), { .integer = 0 }, _ ## id ## _get, _ ## id ## _set }, #endif