From dd075e93c1fa0f5686432b71290ffa340f74c28d Mon Sep 17 00:00:00 2001 From: David Teigland Date: Thu, 21 Jun 2018 09:21:25 -0500 Subject: [PATCH] coverity warnings about null info in lvmcache.c --- lib/cache/lvmcache.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/cache/lvmcache.c b/lib/cache/lvmcache.c index 1b405e703..4f1ae1b80 100644 --- a/lib/cache/lvmcache.c +++ b/lib/cache/lvmcache.c @@ -1015,7 +1015,8 @@ static void _filter_duplicate_devs(struct cmd_context *cmd) dm_list_iterate_items_safe(devl, devl2, &_unused_duplicate_devs) { - info = lvmcache_info_from_pvid(devl->dev->pvid, NULL, 0); + if (!(info = lvmcache_info_from_pvid(devl->dev->pvid, NULL, 0))) + continue; if (MAJOR(info->dev->dev) == dt->md_major) { log_debug_devs("Ignoring md component duplicate %s", dev_name(devl->dev)); @@ -1043,7 +1044,8 @@ static void _warn_duplicate_devs(struct cmd_context *cmd) dm_list_iterate_items_safe(devl, devl2, &_unused_duplicate_devs) { /* info for the preferred device that we're actually using */ - info = lvmcache_info_from_pvid(devl->dev->pvid, NULL, 0); + if (!(info = lvmcache_info_from_pvid(devl->dev->pvid, NULL, 0))) + continue; if (!id_write_format((const struct id *)info->dev->pvid, uuid, sizeof(uuid))) stack;