From e27d0271557d4b93e87a70854b3c7f1cc6008155 Mon Sep 17 00:00:00 2001 From: Zdenek Kabelac Date: Wed, 3 Apr 2019 13:01:06 +0200 Subject: [PATCH] thin: resize metadata with data When data are growing, adapt also size of metadata. As we get way too many reports from users doing huge growths of data portion while keep metadata small and avoiding using monitoring. So to enhance the user-experience in case user requests grown of thin-pool (without passing PV list for growth) - lvm2 will automaticaly grown also the metadata part of thin-pool (if possible). --- WHATS_NEW | 1 + lib/metadata/lv_manip.c | 18 ++++++++++++++++++ 2 files changed, 19 insertions(+) diff --git a/WHATS_NEW b/WHATS_NEW index 0f1fe1bcb..00c96b5a6 100644 --- a/WHATS_NEW +++ b/WHATS_NEW @@ -1,5 +1,6 @@ Version 2.03.02 - =================================== + Automatically grow thin metadata, when thin data gets too big. Add synchronization with udev before removing cached devices. Add support for caching VDO LVs and VDOPOOL LVs. Add support for vgsplit with cached devices. diff --git a/lib/metadata/lv_manip.c b/lib/metadata/lv_manip.c index cc391b65a..a13ba31ac 100644 --- a/lib/metadata/lv_manip.c +++ b/lib/metadata/lv_manip.c @@ -5664,6 +5664,24 @@ int lv_resize(struct logical_volume *lv, if (!_lvresize_prepare(&lv, lp, pvh)) return_0; + if (lp->resize != LV_REDUCE && !aux_lv && !lp->poolmetadata_size && + &lv->vg->pvs == pvh && lv_is_thin_pool_data(lv)) { + /* When thin-pool data part is extended, automatically extend also metadata part + * to have the metadata chunks for adressing all data blocks + * Do this only when PV list is not defined and --poolmetadatasize is unspecified */ + aux_lp = *lp; + seg = get_only_segment_using_this_lv(lv); + aux_lp.size = estimate_thin_pool_metadata_size(lp->extents, lv->vg->extent_size, seg->chunk_size); + if (aux_lp.size > seg->metadata_lv->size) { + log_verbose("Also going to resize thin-pool metadata to match bigger data."); + aux_lv = _lvresize_setup_aux(seg->metadata_lv, &aux_lp); + aux_lp.sign = SIGN_NONE; + if (!_lvresize_prepare(&aux_lv, &aux_lp, pvh)) + return_0; + } else + aux_lp.size = 0; + } + if (((lp->resize == LV_REDUCE) || (aux_lv && aux_lp.resize == LV_REDUCE)) && (pvh != &vg->pvs))