shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-08-02 04:22:02 +03:00
Code Releases Activity

cache: handle older metadata format

Browse Source 
When reading older lvm2 metadata for cache-pool - we now handle more
extended syntax - basically we want to enter most setting when
actually creating cached LV.

For this new validation code has been added. However older metadata
without new settings set is now found as invalid.

Fix it by adding default settings for  cache policy  mq
and cache mode  writethrough.
This commit is contained in:
Zdenek Kabelac
2015-11-15 20:03:08 +01:00
parent d9295410e9
commit e31f4b76f4
3 changed files with 76 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
lib/cache_segtype/cache.c
View File

@ -34,6 +34,32 @@ static unsigned _feature_mask;
log_error(t " segment %s of logical volume %s.", ## p, \
dm_config_parent_name(sn), seg->lv->name), 0;
/*
* When older metadata are loaded without newer settings,
* set then to default settings (the one that could have been
* used implicitely at that time).
*
* Needs both segments cache and cache_pool to be loaded.
*/
static int _fix_missing_defaults(struct lv_segment *cpool_seg)
{
if (!cpool_seg->policy_name) {
cpool_seg->policy_name = "mq";
log_verbose("Cache is missing cache policy, using %s.",
cpool_seg->policy_name);
}
if (!cache_mode_is_set(cpool_seg)) {
if (!cache_set_mode(cpool_seg, "writethrough")) {
log_error(INTERNAL_ERROR "Failed to writethrough cache mode.");
return 0;
}
log_verbose("Cache is missing cache mode, using %s.",
get_cache_mode_name(cpool_seg));
}
return 1;
}
static int _cache_pool_text_import(struct lv_segment *seg,
const struct dm_config_node *sn,
@ -115,6 +141,10 @@ static int _cache_pool_text_import(struct lv_segment *seg,
if (!attach_pool_metadata_lv(seg, meta_lv))
return_0;
if (!dm_list_empty(&seg->lv->segs_using_this_lv) &&
!_fix_missing_defaults(seg))
return_0;
return 1;
}
@ -319,6 +349,10 @@ static int _cache_text_import(struct lv_segment *seg,
if (!attach_pool_lv(seg, pool_lv, NULL, NULL))
return_0;
if (!dm_list_empty(&pool_lv->segments) &&
!_fix_missing_defaults(first_seg(pool_lv)))
return_0;
return 1;
}