shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

cleanup: log_info to log_error

Browse Source 
Switch to more appropriate logging level.
This commit is contained in:
Zdenek Kabelac 2016-10-31 18:03:06 +01:00
parent ee13f265f0
commit e3775173b4
5 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
WHATS_NEW
View File

@ -1,5 +1,6 @@
Version 2.02.167 - Version 2.02.167 -
====================================== ======================================
Use log_error in regex and sysfs filter to describe reason of failure.
Fix blkdeactivate to deactivate dev stack if dev on top already unmounted. Fix blkdeactivate to deactivate dev stack if dev on top already unmounted.
Prevent non-synced raid1 repair unless --force Prevent non-synced raid1 repair unless --force
Prevent raid4 creation/conversion on non-supporting kernels Prevent raid4 creation/conversion on non-supporting kernels

1
WHATS_NEW_DM
View File

@ -1,5 +1,6 @@
Version 1.02.136 - Version 1.02.136 -
====================================== ======================================
Log failure of raid device with log_error level.
Use dm_log_with_errno and translate runtime to dm_log only when needed. Use dm_log_with_errno and translate runtime to dm_log only when needed.
Make log messages from dm and lvm library differnt from dmeventd. Make log messages from dm and lvm library differnt from dmeventd.
Notice and Info messages are again logged from dmeventd and its plugins. Notice and Info messages are again logged from dmeventd and its plugins.

2
daemons/dmeventd/plugins/raid/dmeventd_raid.c
View File

@ -76,7 +76,7 @@ static int _process_raid_event(struct dso_state *state, char *params, const char
/* if repair goes OK, report success even if lvscan has failed */ /* if repair goes OK, report success even if lvscan has failed */
if (!dmeventd_lvm2_run_with_lock(state->cmd_lvconvert)) { if (!dmeventd_lvm2_run_with_lock(state->cmd_lvconvert)) {
log_info("Repair of RAID device %s failed.", device); log_error("Repair of RAID device %s failed.", device);
r = 0; r = 0;
} }
} else { } else {

4
lib/filters/filter-regex.c
View File

@ -40,7 +40,7 @@ static int _extract_pattern(struct dm_pool *mem, const char *pat,
break; break;
default: default:
log_info("pattern must begin with 'a' or 'r'"); log_error("Pattern must begin with 'a' or 'r'.");
return 0; return 0;
} }
pat++; pat++;
@ -77,7 +77,7 @@ static int _extract_pattern(struct dm_pool *mem, const char *pat,
*/ */
ptr = r + strlen(r) - 1; ptr = r + strlen(r) - 1;
if (*ptr != sep) { if (*ptr != sep) {
log_info("invalid separator at end of regex"); log_error("Invalid separator at end of regex.");
return 0; return 0;
} }
*ptr = '\0'; *ptr = '\0';

2
lib/filters/filter-sysfs.c
View File

@ -168,7 +168,7 @@ static int _parse_dev(const char *file, FILE *fp, dev_t *result)
} }
if (sscanf(buffer, "%u:%u", &major, &minor) != 2) { if (sscanf(buffer, "%u:%u", &major, &minor) != 2) {
log_info("sysfs device file not correct format"); log_error("Incorrect format for sysfs device file: %s.", file);
return 0; return 0;
} }