shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-03-11 20:58:50 +03:00
Code Releases Activity

toollib: remove unneeded call in process_each_pv

Browse Source 
process_each_pv was doing:

1. lvmcache_seed_infos_from_lvmetad()
   sends pv_list request to lvmetad.

2. get_vgnameids()
   sends vg_list request to lvmetad.

3. _get_all_devices()
   first calls lvmcache_seed_infos_from_lvmetad(),
   which is a no-op if it's already been called.

Because get_vgnameids() does not use the information
from lvmcache_seed_infos_from_lvmetad(), it does not
need to be called prior to get_all_devices where
it is actually needed.
This commit is contained in:
David Teigland 2016-04-07 13:45:26 -05:00
parent a6a32a7c0e
commit e41ee70acc
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tools/toollib.c
View File

@ -3372,12 +3372,6 @@ int process_each_pv(struct cmd_context *cmd,
dev_cache_full_scan(cmd->full_filter); dev_cache_full_scan(cmd->full_filter);
} }
/*
* Need pvid's set on all PVs before processing so that pvid's
* can be compared to find duplicates while processing.
*/
lvmcache_seed_infos_from_lvmetad(cmd);
if (!get_vgnameids(cmd, &all_vgnameids, only_this_vgname, 1)) { if (!get_vgnameids(cmd, &all_vgnameids, only_this_vgname, 1)) {
stack; stack;
return ret; return ret;