shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

Fix bug in cmirror that caused incorrect status info to print on some nodes.

Browse Source 
Looking at the code in cmirrord/local.c, we can see the various different
request types handled in different ways.  Some information that is non-changing
does not need to go around the cluster and can be short-circuited.  For
example, once the cluster mirror is in-sync, it is pointless to continue
sending that query around the cluster.  We can save network bandwidth and reply
directly back to the kernel.  When it comes to status information, there are
two types 'TABLE' and 'INFO'.  The 'TABLE' information never changes and
belongs to the group of requests that can be safely short-circuited.  The
'STATUS' information can change - and will change if a device fails.  Thus it
cannot be short-circuited, but this is exactly what was found.  The 'STATUS'
information request was being short-circuited and therefore never reporting the
failure condition to anyone other than the "server" that experienced it
directly.
This commit is contained in:
Jonathan Earl Brassow 2012-04-26 17:30:49 +00:00
parent 34fbbfe34e
commit e5b9338ada
3 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
WHATS_NEW
View File

@ -1,5 +1,6 @@
Version 2.02.96 - Version 2.02.96 -
================================ ================================
Fix bug in cmirror that caused incorrect status info to print on some nodes.
Remove statement that snapshots cannot be tagged from lvm man page. Remove statement that snapshots cannot be tagged from lvm man page.
Disallow changing cluster attribute of VG while RAID LVs are active. Disallow changing cluster attribute of VG while RAID LVs are active.
Fix lvconvert error message for non-mergeable volumes. Fix lvconvert error message for non-mergeable volumes.

4
daemons/cmirrord/cluster.c
View File

@ -1231,11 +1231,11 @@ out:
_RQ_TYPE(rq->u_rq.request_type), _RQ_TYPE(rq->u_rq.request_type),
rq->originator, (response) ? "YES" : "NO"); rq->originator, (response) ? "YES" : "NO");
else else
LOG_SPRINT(match, "SEQ#=%u, UUID=%s, TYPE=%s, ORIG=%u, RESP=%s, RSPR=%u", LOG_SPRINT(match, "SEQ#=%u, UUID=%s, TYPE=%s, ORIG=%u, RESP=%s, RSPR=%u, error=%d",
rq->u_rq.seq, SHORT_UUID(rq->u_rq.uuid), rq->u_rq.seq, SHORT_UUID(rq->u_rq.uuid),
_RQ_TYPE(rq->u_rq.request_type), _RQ_TYPE(rq->u_rq.request_type),
rq->originator, (response) ? "YES" : "NO", rq->originator, (response) ? "YES" : "NO",
nodeid); nodeid, rq->u_rq.error);
} }
} }

2
daemons/cmirrord/local.c
View File

@ -237,7 +237,6 @@ static int do_local_work(void *data __attribute__((unused)))
case DM_ULOG_GET_REGION_SIZE: case DM_ULOG_GET_REGION_SIZE:
case DM_ULOG_IN_SYNC: case DM_ULOG_IN_SYNC:
case DM_ULOG_GET_SYNC_COUNT: case DM_ULOG_GET_SYNC_COUNT:
case DM_ULOG_STATUS_INFO:
case DM_ULOG_STATUS_TABLE: case DM_ULOG_STATUS_TABLE:
case DM_ULOG_PRESUSPEND: case DM_ULOG_PRESUSPEND:
/* We do not specify ourselves as server here */ /* We do not specify ourselves as server here */
@ -273,6 +272,7 @@ static int do_local_work(void *data __attribute__((unused)))
case DM_ULOG_MARK_REGION: case DM_ULOG_MARK_REGION:
case DM_ULOG_GET_RESYNC_WORK: case DM_ULOG_GET_RESYNC_WORK:
case DM_ULOG_SET_REGION_SYNC: case DM_ULOG_SET_REGION_SYNC:
case DM_ULOG_STATUS_INFO:
case DM_ULOG_IS_REMOTE_RECOVERING: case DM_ULOG_IS_REMOTE_RECOVERING:
case DM_ULOG_POSTSUSPEND: case DM_ULOG_POSTSUSPEND:
r = cluster_send(rq); r = cluster_send(rq);