shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-10-28 03:27:58 +03:00
Code Releases Activity

fix bad 'strcmp's in 'decode_lock_type' - missing !'s

Browse Source 
There was no effect from having this wrong yet, because the
tree of callers only ever cared about the answer to the first
condition (!response), which determines whether a lock is
held or not.  Correct responses, however, are needed soon.
This commit is contained in:
Jonathan Earl Brassow 2011-02-01 17:31:40 +00:00
parent d6833cc7fa
commit e7cb9788c4
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/locking/cluster_locking.c
View File

@ -490,11 +490,11 @@ static int decode_lock_type(const char *response)
{
if (!response)
return LCK_NULL;
else if (strcmp(response, "EX"))
else if (!strcmp(response, "EX"))
return LCK_EXCL;
else if (strcmp(response, "CR"))
else if (!strcmp(response, "CR"))
return LCK_READ;
else if (strcmp(response, "PR"))
else if (!strcmp(response, "PR"))
return LCK_PREAD;
stack;
@ -532,8 +532,8 @@ int query_resource(const char *resource, int *mode)
/*
* All nodes should use CR, or exactly one node
* should held EX. (PR is obsolete)
* If two nodes node reports different locks,
* should hold EX. (PR is obsolete)
* If two nodes report different locks,
* something is broken - just return more important mode.
*/
if (decode_lock_type(response[i].response) > *mode)