shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-03-10 16:58:47 +03:00
Code Releases Activity

wipe_lv: use BLKZEROOUT when possible

Browse Source 
Since BLKZEROOUT ioctl should be supposedly fastest
way how to clear block device start using this ioctl
for zeroing a device. Commonly we do zero typically
small portion of a device (8KiB) - however since we now
also started to zero metadata devices, in the case
of i.e. thin-pool metadata this can go upto ~16GiB
and here the performance starts to be noticable.
This commit is contained in:
Zdenek Kabelac 2020-10-02 19:32:28 +02:00
parent c65d3a6b8a
commit e7fff97b8d
2 changed files with 33 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
WHATS_NEW
View File

@ -1,5 +1,6 @@
Version 2.03.11 - Version 2.03.11 -
================================== ==================================
Support using BLKZEROOUT for clearing devices.
Support interruption when wipping LVs. Support interruption when wipping LVs.
Support interruption for bcache waiting. Support interruption for bcache waiting.
Fix bcache when device has too many failing writes. Fix bcache when device has too many failing writes.

32
lib/metadata/lv_manip.c
View File

@ -33,6 +33,11 @@
#include "lib/label/label.h" #include "lib/label/label.h"
#include "lib/misc/lvm-signal.h" #include "lib/misc/lvm-signal.h"
#ifdef HAVE_BLKZEROOUT
#include <sys/ioctl.h>
#include <linux/fs.h>
#endif
typedef enum { typedef enum {
PREFERRED, PREFERRED,
USE_AREA, USE_AREA,
@ -7713,6 +7718,33 @@ int wipe_lv(struct logical_volume *lv, struct wipe_params wp)
display_size(lv->vg->cmd, zero_sectors), display_size(lv->vg->cmd, zero_sectors),
display_lvname(lv), wp.zero_value); display_lvname(lv), wp.zero_value);
#ifdef HAVE_BLKZEROOUT
if (!test_mode() && !wp.zero_value) {
/* TODO: maybe integrate with bcache_zero_set() */
const uint64_t end = zero_sectors << SECTOR_SHIFT;
uint64_t range[2] = { 0, 1024 * 1024 }; /* zeroing with 1M steps (for better ^C support) */
for (/* empty */ ; range[0] < end; range[0] += range[1]) {
if ((range[0] + range[1]) > end)
range[1] = end - range[0];
if (ioctl(dev->bcache_fd, BLKZEROOUT, &range)) {
if (errno == EINVAL)
goto retry_with_dev_set; /* Kernel without support for BLKZEROOUT */
log_sys_debug("ioctl", "BLKZEROOUT");
sigint_restore();
label_scan_invalidate(dev);
if (sigint_caught())
log_error("Interrupted initialization logical volume %s.",
display_lvname(lv));
else
log_error("Failed to initialize logical volume %s at position " FMTu64 " and size " FMTu64 ".",
display_lvname(lv), range[0], range[1]);
return 0;
}
}
} else
retry_with_dev_set:
#endif
if (!dev_set_bytes(dev, UINT64_C(0), (size_t) zero_sectors << SECTOR_SHIFT, wp.zero_value)) { if (!dev_set_bytes(dev, UINT64_C(0), (size_t) zero_sectors << SECTOR_SHIFT, wp.zero_value)) {
sigint_restore(); sigint_restore();
if (sigint_caught()) { if (sigint_caught()) {