shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

debug: enhance debug messages

Browse Source
This commit is contained in:
Zdenek Kabelac 2019-11-14 17:00:56 +01:00
parent 14e01d6316
commit e92d3bd1f7
1 changed files with 22 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
lib/label/hints.c
View File

@ -192,7 +192,7 @@ static int _hints_exists(void)
if (!stat(_hints_file, &buf)) if (!stat(_hints_file, &buf))
return 1; return 1;
if (errno != ENOENT) if (errno != ENOENT)
log_debug("hints_exist errno %d", errno); log_sys_debug("stat", _hints_file);
return 0; return 0;
} }
@ -203,7 +203,7 @@ static int _nohints_exists(void)
if (!stat(_nohints_file, &buf)) if (!stat(_nohints_file, &buf))
return 1; return 1;
if (errno != ENOENT) if (errno != ENOENT)
log_debug("nohints_exist errno %d", errno); log_sys_debug("stat", _nohints_file);
return 0; return 0;
} }
@ -214,7 +214,7 @@ static int _newhints_exists(void)
if (!stat(_newhints_file, &buf)) if (!stat(_newhints_file, &buf))
return 1; return 1;
if (errno != ENOENT) if (errno != ENOENT)
log_debug("newhints_exist errno %d", errno); log_sys_debug("stat", _newhints_file);
return 0; return 0;
} }
@ -225,7 +225,7 @@ static int _touch_newhints(void)
if (!(fp = fopen(_newhints_file, "w"))) if (!(fp = fopen(_newhints_file, "w")))
return_0; return_0;
if (fclose(fp)) if (fclose(fp))
stack; log_sys_debug("fclose", _newhints_file);
return 1; return 1;
} }
@ -236,7 +236,7 @@ static int _touch_nohints(void)
if (!(fp = fopen(_nohints_file, "w"))) if (!(fp = fopen(_nohints_file, "w")))
return_0; return_0;
if (fclose(fp)) if (fclose(fp))
stack; log_sys_debug("fclose", _nohints_file);
return 1; return 1;
} }
@ -247,26 +247,26 @@ static int _touch_hints(void)
if (!(fp = fopen(_hints_file, "w"))) if (!(fp = fopen(_hints_file, "w")))
return_0; return_0;
if (fclose(fp)) if (fclose(fp))
stack; log_sys_debug("fclose", _hints_file);
return 1; return 1;
} }
static void _unlink_nohints(void) static void _unlink_nohints(void)
{ {
if (unlink(_nohints_file)) if (unlink(_nohints_file) && errno != ENOENT)
log_debug("unlink_nohints errno %d", errno); log_sys_debug("unlink", _nohints_file);
} }
static void _unlink_hints(void) static void _unlink_hints(void)
{ {
if (unlink(_hints_file)) if (unlink(_hints_file) && errno != ENOENT)
log_debug("unlink_hints errno %d", errno); log_sys_debug("unlink", _hints_file);
} }
static void _unlink_newhints(void) static void _unlink_newhints(void)
{ {
if (unlink(_newhints_file)) if (unlink(_newhints_file) && errno != ENOENT)
log_debug("unlink_newhints errno %d", errno); log_sys_debug("unlink", _newhints_file);
} }
static int _clear_hints(struct cmd_context *cmd) static int _clear_hints(struct cmd_context *cmd)
@ -275,7 +275,7 @@ static int _clear_hints(struct cmd_context *cmd)
time_t t; time_t t;
if (!(fp = fopen(_hints_file, "w"))) { if (!(fp = fopen(_hints_file, "w"))) {
log_warn("Failed to clear hint file."); log_warn("WARNING: Failed to clear hint file.");
/* shouldn't happen, but try to unlink in case */ /* shouldn't happen, but try to unlink in case */
_unlink_hints(); _unlink_hints();
return 0; return 0;
@ -286,10 +286,10 @@ static int _clear_hints(struct cmd_context *cmd)
fprintf(fp, "# Created empty by %s pid %d %s", cmd->name, getpid(), ctime(&t)); fprintf(fp, "# Created empty by %s pid %d %s", cmd->name, getpid(), ctime(&t));
if (fflush(fp)) if (fflush(fp))
log_debug("clear_hints flush errno %d", errno); log_sys_debug("fflush", _hints_file);
if (fclose(fp)) if (fclose(fp))
log_debug("clear_hints close errno %d", errno); log_sys_debug("fclose", _hints_file);
return 1; return 1;
} }
@ -313,7 +313,7 @@ static int _lock_hints(struct cmd_context *cmd, int mode, int nonblock)
fd = open(_hints_file, O_RDWR); fd = open(_hints_file, O_RDWR);
if (fd < 0) { if (fd < 0) {
log_debug("lock_hints open errno %d", errno); log_sys_debug("open", _hints_file);
return 0; return 0;
} }
@ -641,10 +641,13 @@ static int _read_hint_file(struct cmd_context *cmd, struct dm_list *hints, int *
int ret = 1; int ret = 1;
int i; int i;
if (!(fp = fopen(_hints_file, "r"))) if (!(fp = fopen(_hints_file, "r"))) {
if (errno != ENOENT)
log_sys_debug("fopen", _hints_file);
return 0; return 0;
}
log_debug("Reading hint file"); log_debug("Reading hint file %s.", _hints_file);
for (i = 0; i < HINT_LINE_WORDS; i++) for (i = 0; i < HINT_LINE_WORDS; i++)
split[i] = NULL; split[i] = NULL;
@ -773,7 +776,7 @@ static int _read_hint_file(struct cmd_context *cmd, struct dm_list *hints, int *
} }
if (fclose(fp)) if (fclose(fp))
stack; log_sys_debug("fclose", _hints_file);
if (!ret) if (!ret)
return 0; return 0;
@ -1354,4 +1357,3 @@ int get_hints(struct cmd_context *cmd, struct dm_list *hints_out, int *newhints,
return 1; return 1;
} }