shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-23 21:35:29 +03:00
Code Releases Activity

Add couple FIXMEs around suspicious code

Browse Source
This commit is contained in:
Zdenek Kabelac 2011-06-17 14:24:18 +00:00
parent 5b1254a741
commit e954b58f29
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/activate/activate.c
View File

@ -795,12 +795,14 @@ static int _lv_is_active(struct logical_volume *lv,
goto out;
}
/* FIXME: Is this fallback alright? */
if (activate_lv_excl(lv->vg->cmd, lv)) {
if (!deactivate_lv(lv->vg->cmd, lv))
stack;
/* FIXME: locally & exclusive are undefined. */
return 0;
}
/* FIXME: Check exclusive value here. */
out:
if (locally)
*locally = l;

1
lib/metadata/mirror.c
View File

@ -2020,6 +2020,7 @@ int lv_add_mirrors(struct cmd_context *cmd, struct logical_volume *lv,
}
if (vg_is_clustered(lv->vg)) {
/* FIXME: review check of lv_is_active_remotely */
if (!(lv->status & ACTIVATE_EXCL) &&
!cluster_mirror_is_available(lv)) {
log_error("Shared cluster mirrors are not available.");