shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-10-12 07:33:16 +03:00
Code Releases Activity

Fix memory leak of allocated bitmap in error path

Browse Source 
Found by static analyzer.
This commit is contained in:
Zdenek Kabelac
2011-09-06 18:15:43 +00:00
parent c5120c1a7a
commit ebb39e1041
2 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
WHATS_NEW
View File

@@ -1,5 +1,6 @@
Version 2.02.89 - Version 2.02.89 -
================================== ==================================
Fix error path bitmap leak in cmirrord import_checkpoint().
Log unlink() error in cmirrord remove_lockfile(). Log unlink() error in cmirrord remove_lockfile().
Remove incorrect requirement for -j or -m from lvchange error message. Remove incorrect requirement for -j or -m from lvchange error message.
Fix unsafe table load when splitting off smaller mirror from a larger one. Fix unsafe table load when splitting off smaller mirror from a larger one.

2
daemons/cmirrord/cluster.c
View File

@@ -619,6 +619,7 @@ open_retry:
if (rv != SA_AIS_OK) { if (rv != SA_AIS_OK) {
LOG_ERROR("[%s] Failed to open checkpoint: %s", LOG_ERROR("[%s] Failed to open checkpoint: %s",
SHORT_UUID(entry->name.value), str_ais_error(rv)); SHORT_UUID(entry->name.value), str_ais_error(rv));
free(bitmap);
return -EIO; /* FIXME: better error */ return -EIO; /* FIXME: better error */
} }
@@ -647,6 +648,7 @@ init_retry:
if (rv != SA_AIS_OK) { if (rv != SA_AIS_OK) {
LOG_ERROR("[%s] Sync checkpoint section creation failed: %s", LOG_ERROR("[%s] Sync checkpoint section creation failed: %s",
SHORT_UUID(entry->name.value), str_ais_error(rv)); SHORT_UUID(entry->name.value), str_ais_error(rv));
free(bitmap);
return -EIO; /* FIXME: better error */ return -EIO; /* FIXME: better error */
} }