mirror of
git://sourceware.org/git/lvm2.git
synced 2024-12-04 08:17:12 +03:00
cov: add explicit NULL pointer check
Make obvious to coverity strcmp() is not getting NULL pointer.
This commit is contained in:
parent
752a9ec4b4
commit
ebd150366f
@ -932,7 +932,7 @@ static int _check_value_differs_from_default(struct cft_check_handle *handle,
|
||||
} else {
|
||||
str = v_def ? v_def->v.str
|
||||
: cfg_def_get_default_value(handle->cmd, def, CFG_TYPE_STRING, NULL);
|
||||
diff = strcmp(str, v->v.str);
|
||||
diff = str ? strcmp(str, v->v.str) : 0;
|
||||
}
|
||||
break;
|
||||
case DM_CFG_EMPTY_ARRAY:
|
||||
|
@ -6426,9 +6426,10 @@ static const struct command *_find_command(const struct command *commands,
|
||||
{
|
||||
int i;
|
||||
|
||||
for (i = 0; commands[i].name; i++)
|
||||
if (!strcmp(commands[i].name, name))
|
||||
return commands + i;
|
||||
if (name)
|
||||
for (i = 0; commands[i].name; i++)
|
||||
if (!strcmp(commands[i].name, name))
|
||||
return commands + i;
|
||||
|
||||
return NULL;
|
||||
}
|
||||
|
@ -240,7 +240,7 @@ static unsigned _filter(const char *pattern, struct test_details **tests, unsign
|
||||
}
|
||||
|
||||
for (i = 0; i < nr; i++)
|
||||
if (!regexec(&rx, tests[i]->path, 0, NULL, 0))
|
||||
if (tests[i] && !regexec(&rx, tests[i]->path, 0, NULL, 0))
|
||||
tests[found++] = tests[i];
|
||||
|
||||
regfree(&rx);
|
||||
|
@ -4015,9 +4015,9 @@ int main(int argc, char *argv[])
|
||||
|
||||
factor_common_options();
|
||||
|
||||
if (primary)
|
||||
if (primary && cmdname)
|
||||
r = _print_man(cmdname, desfile, secondary);
|
||||
else if (secondary) {
|
||||
else if (secondary && cmdname) {
|
||||
r = 1;
|
||||
_print_man_secondary(cmdname);
|
||||
} else if (check) {
|
||||
|
Loading…
Reference in New Issue
Block a user