shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-03-31 14:50:37 +03:00
Code Releases Activity

lvconvert: validate cache conversion to snapshot

Browse Source 
Cache cannot be converted into snapshot cow nor origin.
This commit is contained in:
Zdenek Kabelac 2014-10-06 12:27:35 +02:00
parent f76f2ce1df
commit ee344f1a9e
2 changed files with 19 additions and 4 deletions

1
WHATS_NEW

@ -1,5 +1,6 @@
Version 2.02.112 -
=====================================
Fix detection of unsupported lvconversion of cache to snapshot.
Improve code for creation of cache and cache pool volumes.
Check cluster-wide (not local) active status before removing LV.
Properly check if activation of removed cached LV really activated.

22
tools/lvconvert.c

@ -2139,6 +2139,12 @@ static int _lvconvert_snapshot(struct cmd_context *cmd,
{
struct logical_volume *org;
if (lv_is_cache_type(lv)) {
log_error("Snapshots are not yet supported with cache type LVs %s.",
display_lvname(lv));
return 0;
}
if (lv_is_mirrored(lv)) {
log_error("Unable to convert mirrored LV \"%s\" into a snapshot.", lv->name);
return 0;
@ -2150,14 +2156,15 @@ static int _lvconvert_snapshot(struct cmd_context *cmd,
return 0;
}
if (lv_is_cache_type(lv)) {
log_error("Snapshots are not yet supported with cache type LVs %s.",
if (lv_is_pool(lv)) {
log_error("Unable to convert pool LVs %s into a snapshot.",
display_lvname(lv));
return 0;
}
if (!(org = find_lv(lv->vg, lp->origin_lv_name))) {
log_error("Couldn't find origin volume %s.", lp->origin_lv_name);
log_error("Couldn't find origin volume %s in Volume group %s.",
lp->origin_lv_name, lv->vg->name);
return 0;
}
@ -2170,9 +2177,16 @@ static int _lvconvert_snapshot(struct cmd_context *cmd,
if (!cow_has_min_chunks(lv->vg, lv->le_count, lp->chunk_size))
return_0;
if (lv_is_locked(org) || lv_is_pvmove(org) || lv_is_mirrored(org) || lv_is_cow(org)) {
if (lv_is_locked(org) ||
lv_is_cache_type(org) ||
lv_is_thin_type(org) ||
lv_is_pvmove(org) ||
lv_is_mirrored(org) ||
lv_is_cow(org)) {
log_error("Unable to convert an LV into a snapshot of a %s LV.",
lv_is_locked(org) ? "locked" :
lv_is_cache_type(org) ? "cache type" :
lv_is_thin_type(org) ? "thin type" :
lv_is_pvmove(org) ? "pvmove" :
lv_is_mirrored(org) ? "mirrored" :
"snapshot");