shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

cmdline: avoid overrun on very large numbers.

Browse Source 
When large size number (>2^31) is given on command line it could be
misdetected and in certain cases lead to wrongly casted number.

So make sure all cases always do set _MAX number in case the value would
not fit within the supported range instead of getting some random value
within the range.

In most cases this was not a problem to detect, but i.e. stripesize
parameter might have been fooled by certain large numbers.
This commit is contained in:
Zdenek Kabelac 2017-11-27 10:21:21 +01:00
parent 34eb082bbc
commit efa17cae24
2 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
WHATS_NEW
View File

@ -1,5 +1,6 @@
Version 2.02.177 - Version 2.02.177 -
==================================== ====================================
Ensure very large numbers used as arguments are not casted to lower values.
Enhance reading and validation of options stripes and stripes_size. Enhance reading and validation of options stripes and stripes_size.
Fix printing of default stripe size when user is not using stripes. Fix printing of default stripe size when user is not using stripes.
Activation code for pvmove automatically discovers holding LVs for resume. Activation code for pvmove automatically discovers holding LVs for resume.

17
tools/lvmcmdline.c
View File

@ -508,10 +508,10 @@ static int _get_int_arg(struct arg_values *av, char **ptr)
if (*ptr == val || errno) if (*ptr == val || errno)
return 0; return 0;
av->i_value = (int32_t) v; av->i_value = (v < INT32_MAX) ? (int32_t) v : INT32_MAX;
av->ui_value = (uint32_t) v; av->ui_value = (v < UINT32_MAX) ? (uint32_t) v : UINT32_MAX;
av->i64_value = (int64_t) v; av->i64_value = (v < INT64_MAX) ? (int64_t) v : INT64_MAX;
av->ui64_value = (uint64_t) v; av->ui64_value = (v < UINT64_MAX) ? (uint64_t) v : UINT64_MAX;
return 1; return 1;
} }
@ -641,10 +641,11 @@ static int _size_arg(struct cmd_context *cmd __attribute__((unused)),
log_error("Size is too big (>=16EiB)."); log_error("Size is too big (>=16EiB).");
return 0; return 0;
} }
av->i_value = (int32_t) v;
av->ui_value = (uint32_t) v; av->i_value = (v < INT32_MAX) ? (int32_t) v : INT32_MAX;
av->i64_value = (int64_t) v; av->ui_value = (v < UINT32_MAX) ? (uint32_t) v : UINT32_MAX;
av->ui64_value = (uint64_t) v; av->i64_value = (v < INT64_MAX) ? (int64_t) v : INT64_MAX;
av->ui64_value = (v < UINT64_MAX) ? (uint64_t) v : UINT64_MAX;
return 1; return 1;
} }