From f02cdcff0084a323c9651d7ca2f22d60c83bcf3d Mon Sep 17 00:00:00 2001 From: Peter Rajnoha Date: Tue, 4 Aug 2015 10:16:45 +0200 Subject: [PATCH] coverity: check vg->lvm1_system_id is not NULL before calling strncmp with that lib/format1/import-export.c:167: var_deref_model: Passing null pointer "vg->lvm1_system_id" to "strncmp", which dereferences it. --- lib/format1/import-export.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/format1/import-export.c b/lib/format1/import-export.c index 275583d18..9e49a969c 100644 --- a/lib/format1/import-export.c +++ b/lib/format1/import-export.c @@ -164,7 +164,7 @@ int export_pv(struct cmd_context *cmd, struct dm_pool *mem __attribute__((unused /* Is VG already exported or being exported? */ if (vg && vg_is_exported(vg)) { /* Does system_id need setting? */ - if ((vg->lvm1_system_id && !*vg->lvm1_system_id) || + if (!vg->lvm1_system_id || !*vg->lvm1_system_id || strncmp(vg->lvm1_system_id, EXPORTED_TAG, sizeof(EXPORTED_TAG) - 1)) { if (!generate_lvm1_system_id(cmd, (char *)pvd->system_id, EXPORTED_TAG))