shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

libdm-stats: backtrace if fclose fails (Coverity)

Browse Source 
Since libdm-stats only uses fmemopen'd FILE objects the only way
that a close can fail is corruption of the memory containing the
FILE: check for this case and emit a backtrace if it occurs.

libdm/libdm-stats.c: 338 in _stats_parse_list()
libdm/libdm-stats.c: 341 in _stats_parse_list()
libdm/libdm-stats.c: 481 in _stats_parse_region()
libdm/libdm-stats.c: 487 in _stats_parse_region()
libdm/libdm-stats.c: 487 in _stats_parse_region()
 - Calling "fclose" without checking return value
This commit is contained in:
Bryn M. Reeves 2015-08-10 19:23:41 +01:00
parent 856f9cced8
commit f072a76326
1 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
libdm/libdm-stats.c
View File

@ -81,11 +81,13 @@ static char *_program_id_from_proc(void)
if (!fgets(buf, sizeof(buf), comm)) { if (!fgets(buf, sizeof(buf), comm)) {
log_error("Could not read from %s", PROC_SELF_COMM); log_error("Could not read from %s", PROC_SELF_COMM);
fclose(comm); if(fclose(comm))
stack;
return NULL; return NULL;
} }
fclose(comm); if (fclose(comm))
stack;
return dm_strdup(buf); return dm_strdup(buf);
} }
@ -340,10 +342,13 @@ static int _stats_parse_list(struct dm_stats *dms, const char *resp)
dms->max_region = max_region - 1; dms->max_region = max_region - 1;
dms->regions = dm_pool_end_object(mem); dms->regions = dm_pool_end_object(mem);
fclose(list_rows); if (fclose(list_rows))
stack;
return 1; return 1;
out: out:
fclose(list_rows); if(fclose(list_rows))
stack;
dm_pool_abandon_object(mem); dm_pool_abandon_object(mem);
return 0; return 0;
} }
@ -483,13 +488,16 @@ static int _stats_parse_region(struct dm_pool *mem, const char *resp,
region->timescale = timescale; region->timescale = timescale;
region->counters = dm_pool_end_object(mem); region->counters = dm_pool_end_object(mem);
fclose(stats_rows); if (fclose(stats_rows))
stack;
return 1; return 1;
out: out:
if (stats_rows) if (stats_rows)
fclose(stats_rows); if(fclose(stats_rows))
stack;
dm_pool_abandon_object(mem); dm_pool_abandon_object(mem);
return 0; return 0;
} }