shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

coverity: fix issues detected in recent code

Browse Source 
Uninitialized variables  (UNINIT) /safe/guest2/covscan/LVM2.2.02.158/tools/toollib.c: 3520 in _process_pvs_in_vgs()
Uninitialized variables  (UNINIT) Using uninitialized value "do_report_ret_code".

Null pointer dereferences  (REVERSE_INULL) /safe/guest2/covscan/LVM2.2.02.158/libdm/libdm-report.c: 4745 in dm_report_output()
Null pointer dereferences  (REVERSE_INULL) Null-checking "rh" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.

Incorrect expression  (MISSING_COMMA) /safe/guest2/covscan/LVM2.2.02.158/lib/log/log.c: 280 in _get_log_level_name()
Incorrect expression  (MISSING_COMMA) In the initialization of "log_level_names", a suspicious concatenated string ""noticeinfo"" is produced.

Null pointer dereferences  (FORWARD_NULL) /safe/guest2/covscan/LVM2.2.02.158/tools/reporter.c: 816 in_get_report_options()
Null pointer dereferences  (FORWARD_NULL) Comparing "mem" to null implies that "mem" might be null.
This commit is contained in:
Peter Rajnoha 2016-06-27 10:12:41 +02:00 committed by Alasdair G Kergon
parent a46f524247
commit f0768f636e
4 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/log/log.c
View File

@ -277,7 +277,7 @@ static const char *_get_log_level_name(int use_stderr, int level)
"fatal", /* _LOG_FATAL */ "fatal", /* _LOG_FATAL */
"error", /* _LOG_ERROR */ "error", /* _LOG_ERROR */
"warn", /* _LOG_WARN */ "warn", /* _LOG_WARN */
"notice" /* _LOG_NOTICE */ "notice",/* _LOG_NOTICE */
"info", /* _LOG_INFO */ "info", /* _LOG_INFO */
"debug" /* _LOG_DEBUG */ "debug" /* _LOG_DEBUG */
}; };

4
libdm/libdm-report.c
View File

@ -4001,7 +4001,7 @@ static int _report_set_selection(struct dm_report *rh, const char *selection, in
goto_bad; goto_bad;
} }
if (!selection || !strcasecmp(selection, SPECIAL_SELECTION_ALL)) if (!selection || !selection[0] || !strcasecmp(selection, SPECIAL_SELECTION_ALL))
return 1; return 1;
rh->selection->add_new_fields = add_new_fields; rh->selection->add_new_fields = add_new_fields;
@ -4742,7 +4742,7 @@ int dm_report_output(struct dm_report *rh)
else else
r = _output_as_columns(rh); r = _output_as_columns(rh);
out: out:
if (r && rh && rh->group_item) if (r && rh->group_item)
rh->group_item->output_done = 1; rh->group_item->output_done = 1;
return r; return r;
} }

2
tools/reporter.c
View File

@ -815,7 +815,7 @@ static int _get_report_options(struct cmd_context *cmd,
if (!(mem = dm_pool_create("report_options", 128))) { if (!(mem = dm_pool_create("report_options", 128))) {
log_error("Failed to create temporary mempool to process report options."); log_error("Failed to create temporary mempool to process report options.");
goto out; return ECMD_FAILED;
} }
if (single_args->report_type == CMDLOG) { if (single_args->report_type == CMDLOG) {

2
tools/toollib.c
View File

@ -3439,7 +3439,7 @@ static int _process_pvs_in_vgs(struct cmd_context *cmd, uint32_t read_flags,
int skip; int skip;
int notfound; int notfound;
int already_locked; int already_locked;
int do_report_ret_code; int do_report_ret_code = 1;
log_set_report_object_type(LOG_REPORT_OBJECT_TYPE_VG); log_set_report_object_type(LOG_REPORT_OBJECT_TYPE_VG);