shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-01-09 01:18:39 +03:00
Code Releases Activity

Fix name conflicts that prevent down-converting RAID1 when specifying a device

Browse Source 
When down-converting a RAID1 device, it is the last device that is extracted
and removed when the user does not specify a particular device.  However,
when a device is specified (and it is not the last), the device is removed and
the remaining sub-LVs are "shifted down" to fill the hole.  This cause problems
when resuming the LV because if the shifted devices were resumed (and thus
renamed) before the sub-LV being extracted, there would be a name conflict.
The solution is to resume the extracted sub-LVs first so that they can be
properly renamed preventing a possible conflict.

This addresses bug 801967.
This commit is contained in:
Jonathan Earl Brassow 2012-03-15 20:00:54 +00:00
parent d7bcb6e117
commit f19be6776b
3 changed files with 21 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
WHATS_NEW
View File

@ -1,5 +1,6 @@
Version 2.02.96 - Version 2.02.96 -
================================ ================================
Fix name conflicts that prevent down-converting RAID1 when specifying a device
Improve thin_check option passing and use configured path. Improve thin_check option passing and use configured path.
Add --with-thin-check configure option for path to thin_check. Add --with-thin-check configure option for path to thin_check.
Detect lvm binary path in lvmetad udev rules. Detect lvm binary path in lvmetad udev rules.

14
lib/metadata/raid_manip.c
View File

@ -1011,9 +1011,21 @@ static int _raid_remove_images(struct logical_volume *lv,
return 0; return 0;
} }
/*
* We resume the extracted sub-LVs first so they are renamed
* and won't conflict with the remaining (possibly shifted)
* sub-LVs.
*/
dm_list_iterate_items(lvl, &removal_list) {
if (!resume_lv(lv->vg->cmd, lvl->lv)) {
log_error("Failed to resume extracted LVs");
return 0;
}
}
/* /*
* Resume original LV * Resume original LV
* This also resumes all other sub-lvs (including the extracted) * This also resumes all other sub-LVs
*/ */
if (!resume_lv(lv->vg->cmd, lv)) { if (!resume_lv(lv->vg->cmd, lv)) {
log_error("Failed to resume %s/%s after committing changes", log_error("Failed to resume %s/%s after committing changes",

7
test/shell/lvconvert-raid.sh
View File

@ -156,6 +156,13 @@ for i in 1 2 3 4; do
done done
done done
done done
# 3-way to 2-way convert while specifying devices
lvcreate --type raid1 -m 2 -l 2 -n $lv1 $vg $dev1 $dev2 $dev3
wait_for_sync $vg/$lv1
lvconvert -m1 $vg/$lv1 $dev2
lvremove -ff $vg
# #
# FIXME: Add tests that specify particular devices to be removed # FIXME: Add tests that specify particular devices to be removed
# #